From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v5 4/9] mfi-common: create
	build-$arch-xsm job
Date: Tue, 3 Feb 2015 13:53:38 +0000
Message-ID: <1422971618.9323.95.camel@citrix.com>
References: <1422959786-22738-1-git-send-email-wei.liu2@citrix.com>
	<1422959786-22738-5-git-send-email-wei.liu2@citrix.com>
	<21712.53678.493828.174956@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21712.53678.493828.174956@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-02-03 at 13:48 +0000, Ian Jackson wrote:
> Wei Liu writes ("[PATCH OSSTEST v5 4/9] mfi-common: create build-$arch-xsm job"):
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > ---
> > Changes in v4:
> > 1. Use "true" and "false" instead of "y" and "n".
> 
> Is this something that I or Ian C suggested ?  It seems to lead to
> extra fiddly code in ts-xen-build to convert it back.

I think it was me...

> Currently make-flight and mfi-common have both y/n and true/false,
> depending on the consumer.

... because I (incorrectly?) observed that true/false was what was in
use elsewhere in runvars (maybe not in the code though?).

$ ./mg-show-flight-runvars 33637 | awk '$3 ~ /true|false/ { print $0}' 
build-amd64                               enable_ovmf                 true
build-armhf                               enable_ovmf                 true
build-i386                                enable_ovmf                 true
build-amd64                               enable_xend                 false
build-armhf                               enable_xend                 false
build-i386                                enable_xend                 false
$ ./mg-show-flight-runvars 33637 | awk '$3 ~ /^[yn]$/ { print $0}' 
$

Ian.