From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 2/2] hvmloader: remove timestamp from vgabios Date: Tue, 3 Feb 2015 16:28:27 +0000 Message-ID: <1422980907.9323.126.camel@citrix.com> References: <1422978845-5908-1-git-send-email-olaf@aepfle.de> <1422978845-5908-3-git-send-email-olaf@aepfle.de> <54D0F202.2070209@citrix.com> <54D102B6020000780005C7EF@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54D102B6020000780005C7EF@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Olaf Hering , Wei Liu , Stefano Stabellini , Andrew Cooper , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2015-02-03 at 16:17 +0000, Jan Beulich wrote: > >>> On 03.02.15 at 17:06, wrote: > > On 03/02/15 15:54, Olaf Hering wrote: > >> Including a timestamp into the binary makes it impossible to get > >> reproducible binaries. Remove the timestamp because it carries no > >> valuable info. > >> > >> Signed-off-by: Olaf Hering > >> Cc: Ian Jackson > >> Cc: Stefano Stabellini > >> Cc: Ian Campbell > >> Cc: Wei Liu > > > > In this case, it would appear that the vgabios_date symbol is completely > > unused inside the binary. Good riddance! > > Let's hope there are no tools scanning the BIOS image for a date > string. That occurred to me too and I forgot to mention it, it looks vaguely like this stuff is trying to conform to something or other (e.g. specific offset and some things which look a bit like signatures), probably some ancient PC spec? Ian.