From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 2/2] hvmloader: remove timestamp from vgabios
Date: Tue, 3 Feb 2015 16:29:22 +0000
Message-ID: <1422980962.9323.127.camel@citrix.com>
References: <1422978845-5908-1-git-send-email-olaf@aepfle.de>
	<1422978845-5908-3-git-send-email-olaf@aepfle.de>
	<54D0F202.2070209@citrix.com> <1422980326.9323.123.camel@citrix.com>
	<54D0F5E5.9070605@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54D0F5E5.9070605@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Olaf Hering <olaf@aepfle.de>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-02-03 at 16:23 +0000, Andrew Cooper wrote:
> On 03/02/15 16:18, Ian Campbell wrote:
> > On Tue, 2015-02-03 at 16:06 +0000, Andrew Cooper wrote:
> >> On 03/02/15 15:54, Olaf Hering wrote:
> >>> Including a timestamp into the binary makes it impossible to get
> >>> reproducible binaries. Remove the timestamp because it carries no
> >>> valuable info.
> >>>
> >>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> >>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> >>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> >>> Cc: Ian Campbell <ian.campbell@citrix.com>
> >>> Cc: Wei Liu <wei.liu2@citrix.com>
> >> In this case, it would appear that the vgabios_date symbol is completely
> >> unused inside the binary.  Good riddance!
> > I think it is actually used because the string at vgabios_version
> > (deliberately) falls through.
> 
> Oh - so it does.  (I misread that as an .asciz).

I'm not going to pretend I spotted it the first time either ;-)

> > Olof, you just removed the nul terminator used there AFAICT. At best
> > this means that the vgabios_copyright is printed twice.
> 
> In which case the 0a/0d and NUL characters need to stay, although the
> single space above vgabios_date can be discarded.

True. (Subject to what Jan wondered about scanning for BIOS strings...)

Ian.