Re: [PATCH] ts-rumpuserxen-build: Use new app-tools

[Ian Campbell <Ian.Campbell@citrix.com>]

On Wed, 2015-02-04 at 12:36 +0100, Martin Lucina wrote:
> Ian.Campbell@citrix.com said:
> > On Wed, 2015-02-04 at 12:21 +0100, Martin Lucina wrote:
> > > Caused by:
> > > 
> > > > commit 3b36d1f55a08e1849ccd5424afb0fbe29647bd6c
> > > > Author: Martin Lucina <martin@lucina.net>
> > > > Date:   Mon Feb 2 18:00:36 2015 +0100
> > > > 
> > > >     Remove even older rumpxen-app-* variants of app-tools
> > > >     
> > > >     Signed-off-by: Martin Lucina <martin@lucina.net>
> > > 
> > > bash: line 14: /home/osstest/build.34129.build-amd64-rumpuserxen/rumpuserxen/app-tools/rumpxen-app-configure: No such file or directory
> > > 
> > > Ian, can you update osstest to use rumprun-xen-configure as discussed on
> > > rumpkernel-users? 
> > 
> > I think we also need Wei's patch from
> > <1422971228-4320-1-git-send-email-wei.liu2@citrix.com> / 
> > http://article.gmane.org/gmane.comp.emulators.xen.devel/230968
> 
> Ack. Patch to update Osstest follows.
> 
> From ff80800099956e429df65bdf7669083cf5c5a8df Mon Sep 17 00:00:00 2001
> From: Martin Lucina <martin@lucina.net>
> Date: Wed, 4 Feb 2015 12:31:33 +0100
> Subject: [PATCH] ts-rumpuserxen-build: Use new app-tools
> 
> Osstest was using old names for rumprun-xen app-tools. These have been
> removed in rumprun-xen commit 3b36d1f55a08e1849ccd5424afb0fbe29647bd6c.
> 
> Update to use the new app-tools names.

I'm not sure if we need to support bisection over this change -- but I
think we probably do (Ian?) in which case we would need to probe for
which one actually exists, preferring the newer name.

Ian?

> 
> Signed-off-by: Martin Lucina <martin@lucina.net>
> ---
>  ts-rumpuserxen-build |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ts-rumpuserxen-build b/ts-rumpuserxen-build
> index 47bcf76..916100b 100755
> --- a/ts-rumpuserxen-build
> +++ b/ts-rumpuserxen-build
> @@ -98,7 +98,7 @@ END
>  }
>  
>  sub recordtools() {
> -    my $apptool = "$rux/app-tools/rumpxen-app";
> +    my $apptool = "$rux/app-tools/rumprun-xen";
>      store_runvar('cmdprefix_configure', "$apptool-configure");
>      store_runvar('cmdprefix_make',      "$apptool-make");
>  }



------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/