From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH] xen/arm: Fix rtds scheduler for arm
Date: Wed, 4 Feb 2015 16:19:24 +0000
Message-ID: <1423066764.4677.26.camel@Abyss>
References: <54CF849D020000780005BEF2@mail.emea.novell.com>
	<1422900219-30012-1-git-send-email-denys.drozdov@globallogic.com>
	<1423062826.24924.17.camel@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5589074592095249972=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1423062826.24924.17.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com, julien.grall@linaro.org, Denis Drozdov <denys.drozdov@globallogic.com>, xen-devel@lists.xen.org, JBeulich@suse.com
List-Id: xen-devel@lists.xenproject.org

--===============5589074592095249972==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-julr1JS+3OkRSaMUYSiw"

--=-julr1JS+3OkRSaMUYSiw
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2015-02-04 at 15:13 +0000, Ian Campbell wrote:
> On Mon, 2015-02-02 at 20:03 +0200, Denis Drozdov wrote:
> > From: denys drozdov <denys.drozdov@globallogic.com>
> >=20
> > Make Credit2 and RT schedulers to run on arm platform
> > context_saved should be deferred on ARM after IRQs enabled
>=20
> A better subject+message would be:
>=20
>         xen/arm: Call context_saved() with interrupts enabled during cont=
ext switch
>        =20
>         This is a requirement of the scheduler interface, violating this
>         causes for example with the RT scheduler:
>                 <insert crash log here>
>=20
> > Signed-off-by: denys drozdov <denys.drozdov@globallogic.com>
>=20
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>=20
> However I would like an ack from a scheduler person (e.g. George) before
> it gets applied.
>=20
Deferring the call to context_saved() until below both
ctxt_switch_from() and ctxt_switch_to(), for ARM, like the patch is
doing seems ok to me.

As Jan noted already, it basically makes things look exactly as they
look in x86 already and, checking how booth credit2 and RTDS use
the .context_saved hook, all seems fine to me.

So, FWIW:

Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-julr1JS+3OkRSaMUYSiw
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlTSRo0ACgkQk4XaBE3IOsQlswCcDecwZJChtSc0liSWpReIddwT
MwgAnAjupFP1pUpSGsZoPNg7OKFVHALy
=SLA6
-----END PGP SIGNATURE-----

--=-julr1JS+3OkRSaMUYSiw--


--===============5589074592095249972==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============5589074592095249972==--