All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	Keir Fraser <keir@xen.org>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>
Subject: Re: [PATCH] common/xz: add comments for the intentionally missing break statements
Date: Wed, 4 Feb 2015 16:34:47 +0000	[thread overview]
Message-ID: <1423067687.24924.33.camel@citrix.com> (raw)
In-Reply-To: <54D25209020000780005CF12@mail.emea.novell.com>

On Wed, 2015-02-04 at 16:08 +0000, Jan Beulich wrote:
> Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
> [Linux commit 84d517f3e56f7d0d305c14a701cee8f7372ebe1e]
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: IAn Campbell <ian.campbell@citrix.com>

> 
> --- a/xen/common/xz/dec_lzma2.c
> +++ b/xen/common/xz/dec_lzma2.c
> @@ -1043,6 +1043,8 @@ XZ_EXTERN enum xz_ret INIT xz_dec_lzma2_
>  
>  			s->lzma2.sequence = SEQ_LZMA_PREPARE;
>  
> +		/* Fall through */
> +
>  		case SEQ_LZMA_PREPARE:
>  			if (s->lzma2.compressed < RC_INIT_BYTES)
>  				return XZ_DATA_ERROR;
> @@ -1053,6 +1055,8 @@ XZ_EXTERN enum xz_ret INIT xz_dec_lzma2_
>  			s->lzma2.compressed -= RC_INIT_BYTES;
>  			s->lzma2.sequence = SEQ_LZMA_RUN;
>  
> +		/* Fall through */
> +
>  		case SEQ_LZMA_RUN:
>  			/*
>  			 * Set dictionary limit to indicate how much we want
> 
> 
> 

      reply	other threads:[~2015-02-04 16:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 16:08 [PATCH] common/xz: add comments for the intentionally missing break statements Jan Beulich
2015-02-04 16:34 ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423067687.24924.33.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir@xen.org \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.