From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH RFC 31/35] arm : acpi map status override table to dom0 Date: Thu, 5 Feb 2015 11:47:45 +0000 Message-ID: <1423136865.24924.84.camel@citrix.com> References: <1423058539-26403-1-git-send-email-parth.dixit@linaro.org> <1423058539-26403-32-git-send-email-parth.dixit@linaro.org> <54D2FE96.9090900@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Parth Dixit Cc: Julien Grall , tim@xen.org, xen-devel , Stefano Stabellini , Jan Beulich , Christoffer Dall List-Id: xen-devel@lists.xenproject.org On Thu, 2015-02-05 at 16:27 +0530, Parth Dixit wrote: > >> + stao->header.length = sizeof(struct acpi_table_header) + 1; > >> + stao->header.checksum = 0; > >> + ACPI_MEMCPY(stao->header.oem_id, "LINARO", 6); > >> + ACPI_MEMCPY(stao->header.oem_table_id, "RTSMVEV8", 8); > > > > > > I though the plan was to use a Xen OEM ID? > yes, but its not clear what should be used as xen oem id is not finalized yet. Are these IDs the ones defined for x86 in tools/firmware/hvmloader/acpi/acpi2_0.h: #define ACPI_OEM_ID "Xen" #define ACPI_OEM_TABLE_ID "HVM" #define ACPI_OEM_REVISION 0 #define ACPI_CREATOR_ID ASCII32('H','V','M','L') /* HVMLoader */ #define ACPI_CREATOR_REVISION 0 ? If so we should reuse them, although maybe not OEM_TABLE_ID and CREATOR_ID since those are x86/HVM specific. What is the process for assigning those? Given our unique OEM_ID are we allowed to just declare them ourselves? Ian.