From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH RFC 02/35] xen: arm64: ACPI: Support common ACPI drivers Date: Thu, 5 Feb 2015 11:57:01 +0000 Message-ID: <1423137421.24924.89.camel@citrix.com> References: <1423058539-26403-1-git-send-email-parth.dixit@linaro.org> <1423058539-26403-3-git-send-email-parth.dixit@linaro.org> <54D258A8.4090808@linaro.org> <1423134298.24924.67.camel@citrix.com> <54D363AA020000780005D39B@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54D363AA020000780005D39B@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Naresh Bhat , Julien Grall , tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, parth.dixit@linaro.org, christoffer.dall@linaro.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-02-05 at 11:35 +0000, Jan Beulich wrote: > >>> On 05.02.15 at 12:04, wrote: > > On Wed, 2015-02-04 at 17:36 +0000, Julien Grall wrote: > >> I would move the whole function (acpi_os_map_memory) per-architecture. > > > > That's an option too, since once the "/* The low first Mb is always > > mapped. */" bit is removed (which it should be since it is x86 specific) > > then there isn't much left. > > But it's an OS interface function ACPI CA wants, and as such it > belongs into osl.c. OK, then it certainly needs an X86 ifdef around the first-Mb stuff, and for the __acpi_map thing to be arch specific rather than ifdef'd. Ian