From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] libvchan: address compiler warnings
Date: Thu, 5 Feb 2015 12:47:40 +0000
Message-ID: <1423140460.24924.107.camel@citrix.com>
References: <54D251E4020000780005CF0E@mail.emea.novell.com>
	<20150204162636.GA4311@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YJLqS-0008Q9-RO
	for xen-devel@lists.xenproject.org; Thu, 05 Feb 2015 12:47:44 +0000
In-Reply-To: <20150204162636.GA4311@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-02-04 at 16:26 +0000, Wei Liu wrote:
> On Wed, Feb 04, 2015 at 04:07:48PM +0000, Jan Beulich wrote:
> > Both vchan_wr() and stdout_wr() should be defined with a non-empty
> > argument list (i.e. void). Additionally both of them as well as usage()
> > should be static to make clear that no other code is referencing them.
> > 
> > Further, statements should follow declarations.
> > 
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > 
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>

Me too, plus applied. Thanks.

Ian.