From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] xen/arm: Call context_saved() with interrupts enabled during context switch Date: Thu, 5 Feb 2015 12:48:08 +0000 Message-ID: <1423140488.24924.108.camel@citrix.com> References: <54D24CBA.50705@linaro.org> <1423069985-26282-1-git-send-email-denys.drozdov@globallogic.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423069985-26282-1-git-send-email-denys.drozdov@globallogic.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Denis Drozdov Cc: george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com, julien.grall@linaro.org, JBeulich@suse.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-02-04 at 19:13 +0200, Denis Drozdov wrote: > From: denys drozdov > > This is a requirement of the scheduler interface, violating this > causes for example with the RT scheduler: > > (XEN) Assertion 'local_irq_is_enabled()' failed at spinlock.c:137 > (XEN) ----[ Xen-4.5.0 arm32 debug=y Not tainted ]---- > (XEN) CPU: 0 > (XEN) PC: 0022a074 _spin_lock_irq+0x18/0x94 > > (XEN) Xen call trace: > (XEN) [<0022a074>] _spin_lock_irq+0x18/0x94 (PC) > (XEN) [<002256b8>] rt_context_saved+0x3c/0x144 (LR) > (XEN) [<002256b8>] rt_context_saved+0x3c/0x144 > (XEN) [<00228ed8>] context_saved+0x4c/0x80 > (XEN) [<002524b4>] schedule_tail+0x148/0x2f0 > (XEN) [<00252668>] continue_new_vcpu+0xc/0x70 > (XEN) [<00252a18>] context_switch+0x74/0x7c > > > Signed-off-by: denys drozdov > Acked-by: Ian Campbell > Reviewed-by: Dario Faggioli > Reviewed-by: Julien Grall Dario's R-by counts as the scheduled ack I was looking for, so applied thanks.