From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755626AbbBGDfn (ORCPT ); Fri, 6 Feb 2015 22:35:43 -0500 Received: from smtprelay0254.hostedemail.com ([216.40.44.254]:50327 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751246AbbBGDfm (ORCPT ); Fri, 6 Feb 2015 22:35:42 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2689:2828:3138:3139:3140:3141:3142:3350:3622:3865:3866:3867:3871:3873:4321:5007:6261:7903:10004:10400:10848:11658:11914:12296:12517:12519:12740:13069:13071:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: paint28_146193e207a5e X-Filterd-Recvd-Size: 1443 Message-ID: <1423280138.2933.3.camel@perches.com> Subject: Re: [PATCH] vxlan: Wrong type passed to %pIS From: Joe Perches To: Rasmus Villemoes Cc: "David S. Miller" , Pravin B Shelar , Nicolas Dichtel , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 06 Feb 2015 19:35:38 -0800 In-Reply-To: <1423275451-3663-1-git-send-email-linux@rasmusvillemoes.dk> References: <1423275451-3663-1-git-send-email-linux@rasmusvillemoes.dk> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-02-07 at 03:17 +0100, Rasmus Villemoes wrote: > src_ip is a pointer to a union vxlan_addr, one member of which is a > struct sockaddr. Passing a pointer to src_ip is wrong; one should pass > the value of src_ip itself. Since %pIS formally expects something of > type struct sockaddr*, let's pass a pointer to the appropriate union > member, though this of course doesn't change the generated code. Hello Rasmus Are you finding these mismatches by hand or are you using some tool?