From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v3 20/20] arm: mach-pxa: Decrement the power supply's device reference counter Date: Mon, 09 Feb 2015 11:07:12 +0100 Message-ID: <1423476432.4909.15.camel@AMDC1943> References: <1422629278-12202-1-git-send-email-k.kozlowski@samsung.com> <1422629278-12202-21-git-send-email-k.kozlowski@samsung.com> <20150206134953.GA25683@amd> <1423233788.31516.5.camel@AMDC1943> <20150206145904.GA7872@amd> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <20150206145904.GA7872@amd> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Pavel Machek Cc: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Rafael J. Wysocki" , Len Brown , Jiri Kosina , David Herrmann , Cezary Jackiewicz , Darren Hart , Support Opensource , Milo Kim , Julian Andres Klode , Marc Dietrich , Greg Kroah-Hartman , linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org, ac100-oU9gvf+ajcQ97yFScArB1dHuzzzSOjJt@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, Linus Walleij , Samuel List-Id: linux-acpi@vger.kernel.org On pi=C4=85, 2015-02-06 at 15:59 +0100, Pavel Machek wrote: > On Fri 2015-02-06 15:43:08, Krzysztof Kozlowski wrote: > > On pi=C4=85, 2015-02-06 at 14:49 +0100, Pavel Machek wrote: > > > On Fri 2015-01-30 15:47:58, Krzysztof Kozlowski wrote: > > > > Use power_supply_put() to decrement the power supply's device r= eference > > > > counter. > > > >=20 > > > > Signed-off-by: Krzysztof Kozlowski > > > > Reviewed-by: Bartlomiej Zolnierkiewicz > > > > Reviewed-by: Sebastian Reichel > > >=20 > > > 11,13,20 nothing obviously wrong. But I'm not sure if I studied t= hem > > > closely enough to warrant an ACK. > > >=20 > > > It would be good to get this into kernel -- I seen no bad comment= s, > > > and it is not going to improve without merge into mainline. > >=20 > > Thanks for looking at patchset. It would be really nice if this cou= ld be > > tested for some time in linux-next. Such testing would help a lot. = But I > > need acks from various maintainers for that. >=20 > Actually, you don't. The various maintainers clearly don't care at > this point. They had enough time. So you select one maintainer you > want to push this through, and you push it. >=20 > Someone may complain, so you'll solve the feedback... I am thinking also on another way of solving this huge-patch problem: 1. Mark all drivers broken (CONFIG_BROKEN). 2. Introduce change in power_supply_register() API. Broken drivers will fail to build. 3. Convert broken drivers to new API incrementally (one driver per patch) marking them also non-broken. This would be much easier to review but also this would break build-bisectability for drivers and some platforms using them (like OLPC, compal-laptop, ACPI). In case of important platforms (like ACPI) I could do the old-way: change the driver along with API change. What do you think about this? I pushed the patchset here: https://git.linaro.org/people/marek.szyprowski/linux-srpol.git/shortlog= /refs/heads/v3.19-next-power-supply-core-ownership (actually this is v4: added acks/reviews and minor issue fixed; merge window has opened so I'll wait with sending this to LKML). Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Mon, 09 Feb 2015 11:07:12 +0100 Subject: [PATCH v3 20/20] arm: mach-pxa: Decrement the power supply's device reference counter In-Reply-To: <20150206145904.GA7872@amd> References: <1422629278-12202-1-git-send-email-k.kozlowski@samsung.com> <1422629278-12202-21-git-send-email-k.kozlowski@samsung.com> <20150206134953.GA25683@amd> <1423233788.31516.5.camel@AMDC1943> <20150206145904.GA7872@amd> Message-ID: <1423476432.4909.15.camel@AMDC1943> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On pi?, 2015-02-06 at 15:59 +0100, Pavel Machek wrote: > On Fri 2015-02-06 15:43:08, Krzysztof Kozlowski wrote: > > On pi?, 2015-02-06 at 14:49 +0100, Pavel Machek wrote: > > > On Fri 2015-01-30 15:47:58, Krzysztof Kozlowski wrote: > > > > Use power_supply_put() to decrement the power supply's device reference > > > > counter. > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > Reviewed-by: Bartlomiej Zolnierkiewicz > > > > Reviewed-by: Sebastian Reichel > > > > > > 11,13,20 nothing obviously wrong. But I'm not sure if I studied them > > > closely enough to warrant an ACK. > > > > > > It would be good to get this into kernel -- I seen no bad comments, > > > and it is not going to improve without merge into mainline. > > > > Thanks for looking at patchset. It would be really nice if this could be > > tested for some time in linux-next. Such testing would help a lot. But I > > need acks from various maintainers for that. > > Actually, you don't. The various maintainers clearly don't care at > this point. They had enough time. So you select one maintainer you > want to push this through, and you push it. > > Someone may complain, so you'll solve the feedback... I am thinking also on another way of solving this huge-patch problem: 1. Mark all drivers broken (CONFIG_BROKEN). 2. Introduce change in power_supply_register() API. Broken drivers will fail to build. 3. Convert broken drivers to new API incrementally (one driver per patch) marking them also non-broken. This would be much easier to review but also this would break build-bisectability for drivers and some platforms using them (like OLPC, compal-laptop, ACPI). In case of important platforms (like ACPI) I could do the old-way: change the driver along with API change. What do you think about this? I pushed the patchset here: https://git.linaro.org/people/marek.szyprowski/linux-srpol.git/shortlog/refs/heads/v3.19-next-power-supply-core-ownership (actually this is v4: added acks/reviews and minor issue fixed; merge window has opened so I'll wait with sending this to LKML). Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932635AbbBIKH0 (ORCPT ); Mon, 9 Feb 2015 05:07:26 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:33629 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760453AbbBIKHV (ORCPT ); Mon, 9 Feb 2015 05:07:21 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfec7f4-b7f126d000001e9a-cd-54d886443e20 Content-transfer-encoding: 8BIT Message-id: <1423476432.4909.15.camel@AMDC1943> Subject: Re: [PATCH v3 20/20] arm: mach-pxa: Decrement the power supply's device reference counter From: Krzysztof Kozlowski To: Pavel Machek Cc: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Jiri Kosina , David Herrmann , Cezary Jackiewicz , Darren Hart , Support Opensource , Milo Kim , Julian Andres Klode , Marc Dietrich , Greg Kroah-Hartman , linux-acpi@vger.kernel.org, linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org, patches@opensource.wolfsonmicro.com, ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, Linus Walleij , Samuel Ortiz , Lee Jones , linux-arm-kernel@lists.infradead.org, Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Thomas Gleixner , Kyungmin Park , Bartlomiej Zolnierkiewicz Date: Mon, 09 Feb 2015 11:07:12 +0100 In-reply-to: <20150206145904.GA7872@amd> References: <1422629278-12202-1-git-send-email-k.kozlowski@samsung.com> <1422629278-12202-21-git-send-email-k.kozlowski@samsung.com> <20150206134953.GA25683@amd> <1423233788.31516.5.camel@AMDC1943> <20150206145904.GA7872@amd> X-Mailer: Evolution 3.10.4-0ubuntu2 X-Brightmail-Tracker: H4sIAAAAAAAAA02SV0xTcRTG8+8dvTTUXAri3zqIENBgZKiJR2OcRG/UB40kJMYoFW4osUVs BceDshxUbFHUmILKtAxthapBRRRoUVoZAtESpaiAoIAyXMFJ4UHfvpzzne/7PRyGkCRTUiY2 7gCvipMpfGkRaf/9uH1R2AlHeIjVORO0jcMCKL9koqDwyWkSUn59IOFczycCqp6OC6GgzRs0 eSFwtiSLgNQCEw0txmVwsXwGXBu5SsP9nAISGlMGhdD1xYrg7pshGs7/NAjAUK1DUNH9nIKO 0a8UtN3LoWHsjAVB+mc9DS/bxJDenIfAMG4kofVR7sTB0B8aOm1WGsqq+gl4am+lQD/oCfbT FNjvH4AHx58RYK64QMD3m93UmgAuLTWD5opHgzlndR3J6YxjFHdX3ynkhkd2cb2ZWULOXBzI 9XwwUFxFaTrNvXpeRXMfm5qE3JWGbdzDy9cnDIXHOGvGK3KrdIdoZTSviE3kVcGrIkXylmwd EV/tcajsbQZKQqemaZAbg9ml2DRgEUxpb9ziNNEaJGIkbBHCzuR+2rUQsx74e5aT1CCGIVgf bGnd6xoT7Hx87ko+4dISdgzhFHvYlD0Y15Y0TmZ6stH49RuT0KVpdgk2GwonI70mYm5riwlX F8GOi/CvohLkWpCsP243p01qN3YBHqjJFk4V9CHc1Sd3MWDWDyfrNmQiVv8fnf4fnf4/ulxE lKLpfEJUvHpPjDI0SC1TqhPiYoKi9ikr0NTbfK5EBfUrahHLIF93Mfi9CJdQskT1YWUtwgzh 6yX+JneES8TRssNHeNW+3aoEBa+uRQLGTZqE/G0nNjdq2xLvlLntXL39UD1vvDg8Z7njQsva Vlvs0Xs+/Ym6/rT9cjppXr6loxNJHc2eBFbcWjfTHDlLUbnw/faozLnb+gobyJgtvaot6rk/ +PUHIxrWjOS5G7P5gKE/i5VdfsGzZycztlmLQk8O1miHY8Qb3Uvf9WzquBFRN+DvS6rlstBA QqWW/QVGntVHFAMAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On pią, 2015-02-06 at 15:59 +0100, Pavel Machek wrote: > On Fri 2015-02-06 15:43:08, Krzysztof Kozlowski wrote: > > On pią, 2015-02-06 at 14:49 +0100, Pavel Machek wrote: > > > On Fri 2015-01-30 15:47:58, Krzysztof Kozlowski wrote: > > > > Use power_supply_put() to decrement the power supply's device reference > > > > counter. > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > Reviewed-by: Bartlomiej Zolnierkiewicz > > > > Reviewed-by: Sebastian Reichel > > > > > > 11,13,20 nothing obviously wrong. But I'm not sure if I studied them > > > closely enough to warrant an ACK. > > > > > > It would be good to get this into kernel -- I seen no bad comments, > > > and it is not going to improve without merge into mainline. > > > > Thanks for looking at patchset. It would be really nice if this could be > > tested for some time in linux-next. Such testing would help a lot. But I > > need acks from various maintainers for that. > > Actually, you don't. The various maintainers clearly don't care at > this point. They had enough time. So you select one maintainer you > want to push this through, and you push it. > > Someone may complain, so you'll solve the feedback... I am thinking also on another way of solving this huge-patch problem: 1. Mark all drivers broken (CONFIG_BROKEN). 2. Introduce change in power_supply_register() API. Broken drivers will fail to build. 3. Convert broken drivers to new API incrementally (one driver per patch) marking them also non-broken. This would be much easier to review but also this would break build-bisectability for drivers and some platforms using them (like OLPC, compal-laptop, ACPI). In case of important platforms (like ACPI) I could do the old-way: change the driver along with API change. What do you think about this? I pushed the patchset here: https://git.linaro.org/people/marek.szyprowski/linux-srpol.git/shortlog/refs/heads/v3.19-next-power-supply-core-ownership (actually this is v4: added acks/reviews and minor issue fixed; merge window has opened so I'll wait with sending this to LKML). Best regards, Krzysztof