From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH 05/10] sg-run-job: testid generation: Move spawn-step-begin Date: Mon, 9 Feb 2015 13:58:31 +0000 Message-ID: <1423490311.4508.28.camel@citrix.com> References: <1423250275-20872-1-git-send-email-ian.jackson@eu.citrix.com> <1423250275-20872-6-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YKorH-0000mS-Rp for xen-devel@lists.xenproject.org; Mon, 09 Feb 2015 13:58:39 +0000 In-Reply-To: <1423250275-20872-6-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Fri, 2015-02-06 at 19:17 +0000, Ian Jackson wrote: > Run spawn-step-begin until after the loop over $args, and after the > computation of the basic deftestid. > > No functional change: nothing in that loop looks at stepno. > > Signed-off-by: Ian Jackson TBH any Ack I gave here (and to the following TCL patches) would be pretty cursory. I agree with what you seem to be trying to do even if I'm not really in a position to confirm it's what you are actually achieving. I think you can be trusted, and you are running a test flight, and osstest has a push gate of its own. IOW I think you should go ahead on patches 5..8 without an explicit ack... Ian.