From: Patrik Flykt <Patrik.Flykt@linux.intel.com>
To: ell@lists.01.org
Subject: Re: [PATCH 3/9] hashmap: Call user supplied value free function in insert
Date: Wed, 11 Feb 2015 11:27:49 +0200 [thread overview]
Message-ID: <1423646869.5906.137.camel@linux.intel.com> (raw)
In-Reply-To: <54DA598C.6030402@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
On Tue, 2015-02-10 at 13:18 -0600, Denis Kenzior wrote:
> With the current implementation, the item inserted first is
> returned. I don't think enforcement of unique keys is required at the
> hashmap_insert level.
As long as there is no function to read out more than one of the values
from the hashmap, the hashmap should definitely require keys to be
unique. It's way much simpler to require unique keys as the opposite
situation with multiple values per key as it is really uncommon and
shows that the upper level data structure needs a rethought.
Cheers,
Patrik
next prev parent reply other threads:[~2015-02-11 9:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 14:42 [PATCH 0/9] hashmap fixes Jukka Rissanen
2015-02-10 14:42 ` [PATCH 1/9] hashmap: Add value free function Jukka Rissanen
2015-02-10 14:42 ` [PATCH 2/9] hashmap: Call user supplied value free function in destroy Jukka Rissanen
2015-02-10 19:07 ` Denis Kenzior
2015-02-10 14:42 ` [PATCH 3/9] hashmap: Call user supplied value free function in insert Jukka Rissanen
2015-02-10 19:18 ` Denis Kenzior
2015-02-11 9:27 ` Patrik Flykt [this message]
2015-02-11 11:04 ` Tomasz Bursztyka
2015-02-11 13:50 ` Denis Kenzior
2015-02-10 14:42 ` [PATCH 4/9] unit: hashmap: Add value free hash entry test Jukka Rissanen
2015-02-10 14:42 ` [PATCH 5/9] unit: hashmap: Add replace " Jukka Rissanen
2015-02-10 14:42 ` [PATCH 6/9] hashmap: Add re-entrancy support to foreach function Jukka Rissanen
2015-02-10 19:47 ` Denis Kenzior
2015-02-11 9:21 ` Patrik Flykt
2015-02-11 14:06 ` Denis Kenzior
2015-02-12 7:23 ` Jukka Rissanen
2015-02-12 18:02 ` Denis Kenzior
2015-02-12 7:25 ` Jukka Rissanen
2015-02-12 17:55 ` Denis Kenzior
2015-02-13 15:38 ` Luiz Augusto von Dentz
2015-02-13 17:04 ` Denis Kenzior
2015-02-13 17:36 ` Marcel Holtmann
2015-02-16 9:44 ` Luiz Augusto von Dentz
2015-02-16 16:18 ` Marcel Holtmann
2015-02-16 18:27 ` Luiz Augusto von Dentz
2015-02-16 19:03 ` Marcel Holtmann
2015-02-17 9:48 ` Tomasz Bursztyka
2015-02-17 16:41 ` Denis Kenzior
2015-02-18 8:23 ` Tomasz Bursztyka
2015-02-10 14:42 ` [PATCH 7/9] unit: hashmap: Re-entrancy tests added Jukka Rissanen
2015-02-10 14:42 ` [PATCH 8/9] hashmap: Add support to finding an element from hash Jukka Rissanen
2015-02-12 8:35 ` Jukka Rissanen
2015-02-13 0:19 ` Denis Kenzior
2015-02-10 14:42 ` [PATCH 9/9] unit: hashmap: Add unit test for l_hashmap_find Jukka Rissanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423646869.5906.137.camel@linux.intel.com \
--to=patrik.flykt@linux.intel.com \
--cc=ell@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.