From: Ian Kent <ikent@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: autofs@vger.kernel.org, lchiquitto@suse.com
Subject: Re: sloppy mount option not handled by some filesystems.
Date: Wed, 11 Feb 2015 19:17:46 +0800 [thread overview]
Message-ID: <1423653466.2599.39.camel@pluto.fritz.box> (raw)
In-Reply-To: <1423653313.2599.37.camel@pluto.fritz.box>
On Wed, 2015-02-11 at 19:15 +0800, Ian Kent wrote:
> On Wed, 2015-02-11 at 12:03 +0100, Miklos Szeredi wrote:
> > On Wed, Feb 11, 2015 at 11:56 AM, Ian Kent <ikent@redhat.com> wrote:
> > > On Wed, 2015-02-11 at 18:52 +0800, Ian Kent wrote:
> > >> On Wed, 2015-02-11 at 11:11 +0100, Miklos Szeredi wrote:
> > >> > On Wed, Jan 28, 2015 at 12:36 AM, Ian Kent <ikent@redhat.com> wrote:
> > >> >
> > >> > > I could leave it only for NFS, as it supports it anyway, and not pass it
> > >> > > for any other mounts. Then any bug requests could be passed on the the
> > >> > > file system maintainers. Then I could add it for that file system when
> > >> > > done.
> > >> > >
> > >> > > The only annoyance with that approach is the autofs generic mount
> > >> > > module, which is used to mount a number of file systems, would need to
> > >> > > check the file system name to decide whether to add the sloppy option.
> > >> > >
> > >> > > TBH I'm not to fussy about what we do here but we need to make a
> > >> > > decision before I do or I'll end up flipping back and forth.
> > >> > >
> > >> > > So I guess it's up to us to decide, ;)
> > >> > >
> > >> > > I'll post a message to the autofs list once we decide and see if we get
> > >> > > any good arguments to change the approach and we can alter it as needed
> > >> > > (if at all).
> > >> >
> > >> > Hi Ian,
> > >> >
> > >> > Any news about this?
> > >> >
> > >> > There's more and morecomplaints about the new behavior. I'm inclined
> > >> > to just make it NFS-only, as that will restore the old state of
> > >> > affairs.
> > >>
> > >> Good question, I must admit I had forgotten about it since with the
> > >> report I had the subsystem changed to ignore the option.
> > >>
> > >> I was going to not pass it from autofs and I have a patch for that.
> > >> We could use that, after I check I've cover the bases, and I'll commit
> > >> it upstream with the next set of patches (that might be a little while
> > >> though).
> > >
> > > Leaving it for NFS only, of course.
> >
> > Okay.
> >
> > If you have a patch, please let me know and I'll review and test it.
>
> It's pretty simple but should do the trick.
> I have it at the top of the queue now so I can push it without having to
> push the others.
>
> Umm, I didn't even compile test this so please forgive any pain, ;)
> Nevertheless I think this covers the cases.
Oh, sorry, forgot to mention this is against the current autofs master
branch, version 5.1.0 plus patches so, at the very least, you'll
probably need to adjust the CHANGELOG hunk in the patch.
Ian
prev parent reply other threads:[~2015-02-11 11:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 17:09 sloppy mount option not handled by some filesystems Miklos Szeredi
2015-01-27 23:36 ` Ian Kent
2015-02-11 10:11 ` Miklos Szeredi
2015-02-11 10:52 ` Ian Kent
2015-02-11 10:56 ` Ian Kent
2015-02-11 11:03 ` Miklos Szeredi
2015-02-11 11:15 ` Ian Kent
2015-02-11 11:17 ` Ian Kent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423653466.2599.39.camel@pluto.fritz.box \
--to=ikent@redhat.com \
--cc=autofs@vger.kernel.org \
--cc=lchiquitto@suse.com \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.