From: Jukka Rissanen <jukka.rissanen@linux.intel.com>
To: ell@lists.01.org
Subject: Re: [PATCH 6/9] hashmap: Add re-entrancy support to foreach function
Date: Thu, 12 Feb 2015 09:25:32 +0200 [thread overview]
Message-ID: <1423725932.4196.8.camel@linux.intel.com> (raw)
In-Reply-To: <54DB6203.3070107@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
On ke, 2015-02-11 at 08:06 -0600, Denis Kenzior wrote:
> Hi Patrik,
>
> >
> > glib also crashed with this pattern. Or usually worked ok, as the
> > removed/added item wasn't always the item used in foreach or the next
> > item. Fixing this to allow any API call successfully work at any time
> > requires quite some more work to be done, the above patch by Jukka was
> > approximately the minimum needed for a remove to work at any one time.
> >
>
> If you find a good way to fix this in the data structure, great. But
> the current fix is not acceptable. We will not be iterating over the
> _entire_ data structure twice. The foreach operation is already
> expensive and too tempting to abuse.
The patch would iterate the data structure twice only if user did modify
the hash in the callback func. That is probably not very common case
anyway.
Jukka
next prev parent reply other threads:[~2015-02-12 7:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 14:42 [PATCH 0/9] hashmap fixes Jukka Rissanen
2015-02-10 14:42 ` [PATCH 1/9] hashmap: Add value free function Jukka Rissanen
2015-02-10 14:42 ` [PATCH 2/9] hashmap: Call user supplied value free function in destroy Jukka Rissanen
2015-02-10 19:07 ` Denis Kenzior
2015-02-10 14:42 ` [PATCH 3/9] hashmap: Call user supplied value free function in insert Jukka Rissanen
2015-02-10 19:18 ` Denis Kenzior
2015-02-11 9:27 ` Patrik Flykt
2015-02-11 11:04 ` Tomasz Bursztyka
2015-02-11 13:50 ` Denis Kenzior
2015-02-10 14:42 ` [PATCH 4/9] unit: hashmap: Add value free hash entry test Jukka Rissanen
2015-02-10 14:42 ` [PATCH 5/9] unit: hashmap: Add replace " Jukka Rissanen
2015-02-10 14:42 ` [PATCH 6/9] hashmap: Add re-entrancy support to foreach function Jukka Rissanen
2015-02-10 19:47 ` Denis Kenzior
2015-02-11 9:21 ` Patrik Flykt
2015-02-11 14:06 ` Denis Kenzior
2015-02-12 7:23 ` Jukka Rissanen
2015-02-12 18:02 ` Denis Kenzior
2015-02-12 7:25 ` Jukka Rissanen [this message]
2015-02-12 17:55 ` Denis Kenzior
2015-02-13 15:38 ` Luiz Augusto von Dentz
2015-02-13 17:04 ` Denis Kenzior
2015-02-13 17:36 ` Marcel Holtmann
2015-02-16 9:44 ` Luiz Augusto von Dentz
2015-02-16 16:18 ` Marcel Holtmann
2015-02-16 18:27 ` Luiz Augusto von Dentz
2015-02-16 19:03 ` Marcel Holtmann
2015-02-17 9:48 ` Tomasz Bursztyka
2015-02-17 16:41 ` Denis Kenzior
2015-02-18 8:23 ` Tomasz Bursztyka
2015-02-10 14:42 ` [PATCH 7/9] unit: hashmap: Re-entrancy tests added Jukka Rissanen
2015-02-10 14:42 ` [PATCH 8/9] hashmap: Add support to finding an element from hash Jukka Rissanen
2015-02-12 8:35 ` Jukka Rissanen
2015-02-13 0:19 ` Denis Kenzior
2015-02-10 14:42 ` [PATCH 9/9] unit: hashmap: Add unit test for l_hashmap_find Jukka Rissanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423725932.4196.8.camel@linux.intel.com \
--to=jukka.rissanen@linux.intel.com \
--cc=ell@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.