From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH 3/4] drm/i915: Flatten DRIVER_MODESET checks in i915_irq.c Date: Fri, 13 Feb 2015 00:38:50 +0200 Message-ID: <1423780730.3277.19.camel@ideak-mobl> References: <1422959414-18968-1-git-send-email-daniel.vetter@ffwll.ch> <1422959414-18968-3-git-send-email-daniel.vetter@ffwll.ch> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1422959414-18968-3-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyMDE1LTAyLTAzIGF0IDExOjMwICswMTAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ IFVNUyBpcyBubyBtb3JlIQo+IAo+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmll bC52ZXR0ZXJAaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IEltcmUgRGVhayA8aW1yZS5kZWFrQGlu dGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgfCAzNiAr KysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEx IGluc2VydGlvbnMoKyksIDI1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEu Ywo+IGluZGV4IDgwZjM1ZGNmZmVhNC4uMzcxODlhMjVjYTgyIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2lycS5jCj4gQEAgLTU1NywyOCArNTU3LDE2IEBAIHN0YXRpYyB1MzIgaTkxNV9nZXRfdmJs YW5rX2NvdW50ZXIoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IHBpcGUpCj4gIAl1bnNpZ25l ZCBsb25nIGhpZ2hfZnJhbWU7Cj4gIAl1bnNpZ25lZCBsb25nIGxvd19mcmFtZTsKPiAgCXUzMiBo aWdoMSwgaGlnaDIsIGxvdywgcGl4ZWwsIHZibF9zdGFydCwgaHN5bmNfc3RhcnQsIGh0b3RhbDsK PiArCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0KPiArCQl0b19pbnRlbF9jcnRjKGRl dl9wcml2LT5waXBlX3RvX2NydGNfbWFwcGluZ1twaXBlXSk7Cj4gKwljb25zdCBzdHJ1Y3QgZHJt X2Rpc3BsYXlfbW9kZSAqbW9kZSA9Cj4gKwkJJmludGVsX2NydGMtPmNvbmZpZy0+YmFzZS5hZGp1 c3RlZF9tb2RlOwo+ICAKPiAtCWlmIChkcm1fY29yZV9jaGVja19mZWF0dXJlKGRldiwgRFJJVkVS X01PREVTRVQpKSB7Cj4gLQkJc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMgPQo+IC0JCQl0 b19pbnRlbF9jcnRjKGRldl9wcml2LT5waXBlX3RvX2NydGNfbWFwcGluZ1twaXBlXSk7Cj4gLQkJ Y29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUgPQo+IC0JCQkmaW50ZWxfY3J0Yy0+ Y29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGU7Cj4gLQo+IC0JCWh0b3RhbCA9IG1vZGUtPmNydGNf aHRvdGFsOwo+IC0JCWhzeW5jX3N0YXJ0ID0gbW9kZS0+Y3J0Y19oc3luY19zdGFydDsKPiAtCQl2 Ymxfc3RhcnQgPSBtb2RlLT5jcnRjX3ZibGFua19zdGFydDsKPiAtCQlpZiAobW9kZS0+ZmxhZ3Mg JiBEUk1fTU9ERV9GTEFHX0lOVEVSTEFDRSkKPiAtCQkJdmJsX3N0YXJ0ID0gRElWX1JPVU5EX1VQ KHZibF9zdGFydCwgMik7Cj4gLQl9IGVsc2Ugewo+IC0JCWVudW0gdHJhbnNjb2RlciBjcHVfdHJh bnNjb2RlciA9IChlbnVtIHRyYW5zY29kZXIpIHBpcGU7Cj4gLQo+IC0JCWh0b3RhbCA9ICgoSTkx NV9SRUFEKEhUT1RBTChjcHVfdHJhbnNjb2RlcikpID4+IDE2KSAmIDB4MWZmZikgKyAxOwo+IC0J CWhzeW5jX3N0YXJ0ID0gKEk5MTVfUkVBRChIU1lOQyhjcHVfdHJhbnNjb2RlcikpICAmIDB4MWZm ZikgKyAxOwo+IC0JCXZibF9zdGFydCA9IChJOTE1X1JFQUQoVkJMQU5LKGNwdV90cmFuc2NvZGVy KSkgJiAweDFmZmYpICsgMTsKPiAtCQlpZiAoKEk5MTVfUkVBRChQSVBFQ09ORihjcHVfdHJhbnNj b2RlcikpICYKPiAtCQkgICAgIFBJUEVDT05GX0lOVEVSTEFDRV9NQVNLKSAhPSBQSVBFQ09ORl9Q Uk9HUkVTU0lWRSkKPiAtCQkJdmJsX3N0YXJ0ID0gRElWX1JPVU5EX1VQKHZibF9zdGFydCwgMik7 Cj4gLQl9Cj4gKwlodG90YWwgPSBtb2RlLT5jcnRjX2h0b3RhbDsKPiArCWhzeW5jX3N0YXJ0ID0g bW9kZS0+Y3J0Y19oc3luY19zdGFydDsKPiArCXZibF9zdGFydCA9IG1vZGUtPmNydGNfdmJsYW5r X3N0YXJ0Owo+ICsJaWYgKG1vZGUtPmZsYWdzICYgRFJNX01PREVfRkxBR19JTlRFUkxBQ0UpCj4g KwkJdmJsX3N0YXJ0ID0gRElWX1JPVU5EX1VQKHZibF9zdGFydCwgMik7Cj4gIAo+ICAJLyogQ29u dmVydCB0byBwaXhlbCBjb3VudCAqLwo+ICAJdmJsX3N0YXJ0ICo9IGh0b3RhbDsKPiBAQCAtNDMz MCwxMCArNDMxOCw4IEBAIHZvaWQgaW50ZWxfaXJxX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2KQo+ICAJaWYgKCFJU19HRU4yKGRldl9wcml2KSkKPiAgCQlkZXYtPnZibGFu a19kaXNhYmxlX2ltbWVkaWF0ZSA9IHRydWU7Cj4gIAo+IC0JaWYgKGRybV9jb3JlX2NoZWNrX2Zl YXR1cmUoZGV2LCBEUklWRVJfTU9ERVNFVCkpIHsKPiAtCQlkZXYtPmRyaXZlci0+Z2V0X3ZibGFu a190aW1lc3RhbXAgPSBpOTE1X2dldF92YmxhbmtfdGltZXN0YW1wOwo+IC0JCWRldi0+ZHJpdmVy LT5nZXRfc2Nhbm91dF9wb3NpdGlvbiA9IGk5MTVfZ2V0X2NydGNfc2Nhbm91dHBvczsKPiAtCX0K PiArCWRldi0+ZHJpdmVyLT5nZXRfdmJsYW5rX3RpbWVzdGFtcCA9IGk5MTVfZ2V0X3ZibGFua190 aW1lc3RhbXA7Cj4gKwlkZXYtPmRyaXZlci0+Z2V0X3NjYW5vdXRfcG9zaXRpb24gPSBpOTE1X2dl dF9jcnRjX3NjYW5vdXRwb3M7Cj4gIAo+ICAJaWYgKElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKSB7 Cj4gIAkJZGV2LT5kcml2ZXItPmlycV9oYW5kbGVyID0gY2hlcnJ5dmlld19pcnFfaGFuZGxlcjsK CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=