Re: [PATCHv5 00/10] reiser4: batch discard support (FITRIM ioctl): initial implementation.

[Ivan Shapovalov <intelfx100@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1559 bytes --]

On 2015-02-13 at 03:48 +0300, Ivan Shapovalov wrote:
> [...]
> 
> Ivan Shapovalov (10):
>   reiser4: block_alloc: add BA_SOME_SPACE flag for grabbing a fixed amount of space.
>   reiser4: block_alloc: add a "monotonic_forward" parameter to reiser4_blocknr_hint to allocate blocks only in forward direction.
>   reiser4: block_alloc: move block accounting by pre-commit hook into block_alloc.c and document BA_DEFER behavior.
>   reiser4: txnmgr: free allocated but unneeded atom in atom_begin_and_assign_to_txnh().
>   reiser4: txnmgr: add reiser4_create_atom() which creates an empty atom without capturing any nodes.
>   reiser4: txnmgr: move "empty atom" shortcut slightly below.
>   reiser4: batch discard support: add a dummy FITRIM ioctl handler for directories.
>   reiser4: batch discard support: actually implement the FITRIM ioctl handler.
>   reiser4: block_alloc: add a "min_len" parameter to reiser4_blocknr_hint to limit allocated extent length from below.
>   reiser4: batch discard support: honor minimal extent length passed from the userspace.
> 
>  [...]

This is a diff between v4 and v5, for ease of reviewing.

diff --git a/fs/reiser4/plugin/file_ops.c b/fs/reiser4/plugin/file_ops.c
index 7686406..5f0d374 100644
--- a/fs/reiser4/plugin/file_ops.c
+++ b/fs/reiser4/plugin/file_ops.c
@@ -161,7 +161,7 @@ long reiser4_ioctl_dir_common(struct file *file, unsigned int cmd, unsigned long
 	}
 
 	default:
-		ret = RETERR(-ENOSYS);
+		ret = RETERR(-ENOTTY);
 		break;
 	}

-- 
Ivan Shapovalov / intelfx /


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 213 bytes --]