Re: [PATCH v2] depexp.py: Fix segfault if DISPLAY is not set

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2015-02-09 at 14:41 +0100, Maxin B. John wrote:
> bitbake -g -u depexp <package> segfaults when DISPLAY is not set
> properly. Fix it with a proper check.
> 
> [YOCTO #7299]
> 
> Signed-off-by: Maxin B. John <maxin.john@enea.com>
> ---
>  bitbake/lib/bb/ui/depexp.py | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/bitbake/lib/bb/ui/depexp.py b/bitbake/lib/bb/ui/depexp.py
> index 0c71a3e..1b8f0b2 100644
> --- a/bitbake/lib/bb/ui/depexp.py
> +++ b/bitbake/lib/bb/ui/depexp.py
> @@ -17,6 +17,7 @@
>  # with this program; if not, write to the Free Software Foundation, Inc.,
>  # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>  
> +import sys
>  import gobject
>  import gtk
>  import Queue
> @@ -215,6 +216,12 @@ def main(server, eventHandler, params):
>          print("XMLRPC Fault getting commandline:\n %s" % x)
>          return
>  
> +    try:
> +        gtk.init_check()
> +    except:
> +        sys.stderr.write("Please set DISPLAY variable before running this command \n")
> +        return

Sorry about the delay in replying. Its usually bad form to put generic
except clauses into python. Is there a specific exception we should be
trapping here?

Cheers,

Richard