From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 04/10] net/virtio: allocate queue at init
	stage
Date: Mon, 07 Nov 2016 15:23:19 +0100
Message-ID: <14239573.a6YOJCMI3o@xps13>
References: <1478189400-14606-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1478338865-26126-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1478338865-26126-5-git-send-email-yuanhan.liu@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Tan Jianfeng <jianfeng.tan@intel.com>,
 Kevin Traynor <ktraynor@redhat.com>, Ilya Maximets <i.maximets@samsung.com>,
 Kyle Larose <klarose@sandvine.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id 95D271E33
 for <dev@dpdk.org>; Mon,  7 Nov 2016 15:23:21 +0100 (CET)
Received: by mail-wm0-f49.google.com with SMTP id t79so180415081wmt.0
 for <dev@dpdk.org>; Mon, 07 Nov 2016 06:23:21 -0800 (PST)
In-Reply-To: <1478338865-26126-5-git-send-email-yuanhan.liu@linux.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-11-05 17:40, Yuanhan Liu:
> -int virtio_dev_queue_setup(struct rte_eth_dev *dev,
> -=09=09=09int queue_type,
> -=09=09=09uint16_t queue_idx,
> -=09=09=09uint16_t vtpci_queue_idx,
> -=09=09=09uint16_t nb_desc,
> -=09=09=09unsigned int socket_id,
> -=09=09=09void **pvq)
> +static int
> +virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx)=

>  {

I've fixed an error with debug enabled:
drivers/net/virtio/virtio_ethdev.c:335:57: error:
  =E2=80=98nb_desc=E2=80=99 undeclared (first use in this function)
  PMD_INIT_LOG(DEBUG, "vq_size: %u nb_desc:%u", vq_size, nb_desc);
                                                         ^