From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 3/7] sysctl: Make topologyinfo and numainfo sysctls a little more efficient Date: Mon, 16 Feb 2015 14:08:12 +0000 Message-ID: <1424095687.6968.21.camel@citrix.com> References: <1423512275-6531-1-git-send-email-boris.ostrovsky@oracle.com> <1423512275-6531-4-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0540753356978971547==" Return-path: In-Reply-To: <1423512275-6531-4-git-send-email-boris.ostrovsky@oracle.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "boris.ostrovsky@oracle.com" Cc: Wei Liu , Ian Campbell , "port-xen@netbsd.org" , Andrew Cooper , "xen-devel@lists.xen.org" , "jbeulich@suse.com" , Stefano Stabellini , "ufimtseva@gmail.com" , Ian Jackson , "Keir (Xen.org)" List-Id: xen-devel@lists.xenproject.org --===============0540753356978971547== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-LvAvQfnqWTcaoqCAaVla" --=-LvAvQfnqWTcaoqCAaVla Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-02-09 at 15:04 -0500, Boris Ostrovsky wrote: > Currently both of these sysctls make a copy to userspace for each index o= f > various query arrays. We should try to copy whole arrays instead. >=20 > This requires some changes in sysctl's public data structure, thus bump > interface version. >=20 > Report topology for all present (not just online) cpus. >=20 > Rename xen_sysctl_topologyinfo and XEN_SYSCTL_topologyinfo to reflect the= fact > that these are used for CPU topology. Subsequent patch will add support f= or > PCI topology sysctl. >=20 > Clarify some somments in sysctl.h. >=20 > Signed-off-by: Boris Ostrovsky > AFAIUI, this patch will change, so I'll look at it again in next version. What I've seen here seemed all good to me. Dario --=-LvAvQfnqWTcaoqCAaVla Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlTh+ccACgkQk4XaBE3IOsQhKwCcDbr/XzwWiKTyqgU9OQCsywDu 98EAnj/+Orned7JZom9UTxuO0rbX3Ly9 =Ubt2 -----END PGP SIGNATURE----- --=-LvAvQfnqWTcaoqCAaVla-- --===============0540753356978971547== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0540753356978971547==--