From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v5 05/24] libxc: allocate memory with vNUMA
 information for PV guest
Date: Mon, 16 Feb 2015 16:58:11 +0000
Message-ID: <1424105889.2591.56.camel@citrix.com>
References: <1423770294-9779-1-git-send-email-wei.liu2@citrix.com>
	<1423770294-9779-6-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4654972852811070511=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1423770294-9779-6-git-send-email-wei.liu2@citrix.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: "JBeulich@suse.com" <JBeulich@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, "ufimtseva@gmail.com" <ufimtseva@gmail.com>, Ian Jackson <Ian.Jackson@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============4654972852811070511==
Content-Language: en-US
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-U55Y3x0f80NxRtTE98KZ"

--=-U55Y3x0f80NxRtTE98KZ
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2015-02-12 at 19:44 +0000, Wei Liu wrote:

> @@ -760,7 +760,8 @@ static int x86_shadow(xc_interface *xch, domid_t domi=
d)
>  int arch_setup_meminit(struct xc_dom_image *dom)
>  {
>      int rc;
> -    xen_pfn_t pfn, allocsz, i, j, mfn;
> +    xen_pfn_t pfn, allocsz, mfn, total, pfn_base;
> +    int i, j;
> =20
>      rc =3D x86_compat(dom->xch, dom->guest_domid, dom->guest_type);
>      if ( rc )
> @@ -811,26 +812,101 @@ int arch_setup_meminit(struct xc_dom_image *dom)
>              if ( rc )
>                  return rc;
>          }
> -        /* setup initial p2m */
> -        dom->p2m_size =3D dom->total_pages;
> +
> +        /* Setup dummy vNUMA information if it's not provided. Note
> +         * that this is a valid state if libxl doesn't provide any
> +         * vNUMA information.
> +         *
> +         * The dummy values make libxc allocate all pages from
> +         * arbitrary physical. This is the expected behaviour if no
> +         * vNUMA configuration is provided to libxc.
> +         *
"from arbitrary phisical nodes" maybe (or something like that?)

Also, it feels like these two paragraphs can be merged into one. Not a
bit deal, though, and the rest of the patch also looks fine.

Regards,
Dario

--=-U55Y3x0f80NxRtTE98KZ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlTiIaEACgkQk4XaBE3IOsSPBwCgkiOvl1lURiUR1f1A0lGrdmBW
rlEAnjC3cH/4vtEmGHErrhkujgJwRD+Y
=4o8g
-----END PGP SIGNATURE-----

--=-U55Y3x0f80NxRtTE98KZ--


--===============4654972852811070511==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============4654972852811070511==--