All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: dprintk() and gdprintk() to be compiled out when NDEBUG
Date: Wed, 18 Feb 2015 11:40:09 +0000	[thread overview]
Message-ID: <1424259609.27775.25.camel@citrix.com> (raw)
In-Reply-To: <54E480030200007800061029@mail.emea.novell.com>

On Wed, 2015-02-18 at 11:05 +0000, Jan Beulich wrote:
> >>> On 18.02.15 at 11:58, <Ian.Campbell@citrix.com> wrote:
> > On Wed, 2015-02-11 at 07:50 +0000, Jan Beulich wrote:
> >>  Quite likely the (mis-)use of these
> >> two functions may then temporarily result in messages not meant
> >> to be debugging ones to become hidden in non-debug builds. If
> >> others agree, I'd try to make one pass through the tree to try to
> >> identify such,
> > 
> > Thanks, that would be useful I think. Will you cover arch/arm too?
> 
> I did the patch and the auditing pass already, and I skipped - as
> you kind of expected - arch/arm. Since we're not under pressure
> and everyone should be doing debug builds right now anyway, I
> don't think applying the to-be-posted patch without ARM
> adjustments will do much harm; let me know if you think otherwise.

No problem, please go ahead and I'll try and find a moment to audit the
ARM ones separately.

Ian.

      reply	other threads:[~2015-02-18 11:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11  7:50 dprintk() and gdprintk() to be compiled out when NDEBUG Jan Beulich
2015-02-11 10:05 ` Andrew Cooper
2015-02-11 10:32   ` Jan Beulich
2015-02-11 10:34     ` Andrew Cooper
2015-02-18 10:58 ` Ian Campbell
2015-02-18 11:05   ` Jan Beulich
2015-02-18 11:40     ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424259609.27775.25.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.