From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] xen: arm64: more useful logging on bad trap.
Date: Wed, 18 Feb 2015 16:01:35 +0000
Message-ID: <1424275295.20761.30.camel@citrix.com>
References: <1424272771-25072-1-git-send-email-ian.campbell@citrix.com>
	<54E4B191.3040308@linaro.org>
	<CAHyh4xh4Orzeq2d1G-opJXAGu6aveoB15pLZn+=UGCtSZsOJJw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAHyh4xh4Orzeq2d1G-opJXAGu6aveoB15pLZn+=UGCtSZsOJJw@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jintack Lim <jintack@cs.columbia.edu>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Julien Grall <julien.grall@linaro.org>, Tim Deegan <tim@xen.org>, xen-devel <xen-devel@lists.xen.org>, Christoffer Dall <christofferdall@christofferdall.dk>, Shih-Wei Li <shihwei@cs.columbia.edu>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-02-18 at 10:47 -0500, Jintack Lim wrote:
> On Wed, Feb 18, 2015 at 10:19 AM, Ian Campbell <ian.campbell@citrix.com> wrote:
> > Dump the register state before panicing so we have some clue where the
> > issue occurred. Also decode the ESR register a bit to save having to
> > grab a pen and paper.
> >
> > ESR_EL2 is a 32-bit register, so use SYSREG_READ32 not ..._READ64, as
> > we already do correctly in the main trap handler.
> >
> > While here notice that do_trap_serror is never called and remove it.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > Cc: jintack@cs.columbia.edu
> > ---
> > Jintack, since you have a system which is exhibiting SError issues I
> > wonder if I could prevail on you to give this patch a try on your
> > system and report on the output. I've only compile tested this myself.
> > ---
> 
> Hi Ian,
> this is the output I got from the machine.

Thanks, may I add a "Tested-by: Jintack Lim <jintack@cs.columbia.edu>"
please?


> (XEN) Bad mode in Error handler detected, code 0xbf000000, EC=2f, IL=1
> ISS=1000000

I notice I missed a "," here after "IL=1", which I'll fix for v2.

The line is also a bit long so I've split into two lines.

Ian.