From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 5/9] xen: arm: Handle CP15 register traps
 from userspace
Date: Thu, 19 Feb 2015 12:15:17 +0000
Message-ID: <1424348117.30924.56.camel@citrix.com>
References: <1423542956.5851.9.camel@citrix.com>
	<1423543523-8010-5-git-send-email-ian.campbell@citrix.com>
	<54E35944.9030705@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54E35944.9030705@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-02-17 at 15:07 +0000, Julien Grall wrote:
> Hi Ian,
> 
> On 10/02/15 04:45, Ian Campbell wrote:
> >      default:
> > @@ -2047,8 +2070,7 @@ asmlinkage void do_trap_hypervisor(struct cpu_user_regs *regs)
> >          advance_pc(regs, hsr);
> >          break;
> >      case HSR_EC_CP15_32:
> > -        if ( !is_32bit_domain(current->domain) )
> > -            goto bad_trap;
> > +        BUG_ON(!psr_mode_is_32bit(regs->cpsr));
> 
> It's a bit strange that on the previous patch (#5) you fixed CP15_64 but
> not CP15_32. If I'm not mistaken you need both in-order to make the
> things correctly work.

The previous patch (I think you meant #4) made the CP15_64 handlers
correct (since as it happens they are all vtimer related), while it is
only at this point that the cp15_32 registers are all finally updated.

> So, I would invert the 2 patches.

I'm not sure the ordering matters, none of this will be active until the
final patch removes the top-level check. IOW I think the patches make as
much sense in either order and this is the one it has ended up in.

Ian.