From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: libxl__device_pci_reset() questions Date: Thu, 19 Feb 2015 14:30:52 +0000 Message-ID: <1424356252.30924.66.camel@citrix.com> References: <54E5FA4E0200007800061AB4@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YOS8E-0001R8-7L for xen-devel@lists.xenproject.org; Thu, 19 Feb 2015 14:31:10 +0000 In-Reply-To: <54E5FA4E0200007800061AB4@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Ian Jackson , Wei Liu , xen-devel , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Thu, 2015-02-19 at 13:59 +0000, Jan Beulich wrote: > All, > > in the context of someone seeing "The kernel doesn't support reset > from sysfs for PCI device", is my understanding correct that the lack > of error checking in any caller (perhaps intentional) means that any > of the errors logged from this function are really just warnings, i.e. > don't prevent the assignment from taking place? It was a long while ago, but I believe that was the intention, yes. > Furthermore I'm puzzled by the function first thing trying to access > a "do_flr" file supposedly made available by the pciback driver, yet > I can't see either the upstream or the old 2.6.18 driver surfacing > such a file. What am I missing here? I'm not sure, on the basis of http://lists.xen.org/archives/html/xen-devel/2014-06/msg03105.html and http://lists.xen.org/archives/html/xen-devel/2014-07/msg01108.html I've added Konrad to the CC. Ian.