From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v3 11/15] xen/arm: vgic-v2: Correctly handle RAZ/WI registers Date: Thu, 19 Feb 2015 16:07:04 +0000 Message-ID: <1424362024.30924.106.camel@citrix.com> References: <1424098255-22490-1-git-send-email-julien.grall@linaro.org> <1424098255-22490-12-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YOTg3-0004yD-7X for xen-devel@lists.xenproject.org; Thu, 19 Feb 2015 16:10:11 +0000 In-Reply-To: <1424098255-22490-12-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, Vijaya.Kumar@caviumnetworks.com, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Mon, 2015-02-16 at 14:50 +0000, Julien Grall wrote: > All the GICv2 registers are word-accessible. Some them are also > byte-accessible (see GICD_IPRIORITYR*). > > Those registers are incorrectly implemented when they should be RAZ. Only > word-access size are currently allowed for them. > > To avoid further issues, introduce different label following the access-size > of the registers: > - read_as_zero_32 and write_ignore_32: Used for registers accessible > via a word. > - read_as_zero: Used when we don't have to check the access size. > > The latter is used when the access size has already been checked in the > register emulation and/or when the register offset is reserved/implementation > defined. > > Note that, only used labels has been introduced. > > Signed-off-by: Julien Grall Acked-by: Ian Campbell