From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2] xen: arm64: more useful logging on bad trap. Date: Thu, 19 Feb 2015 17:20:17 +0000 Message-ID: <1424366417.30924.145.camel@citrix.com> References: <1424278915-6468-1-git-send-email-ian.campbell@citrix.com> <54E4CB49.1020209@citrix.com> <1424335550.25370.27.camel@citrix.com> <54E5B84C.5000302@citrix.com> <1424341321.30924.46.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1424341321.30924.46.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: xen-devel@lists.xen.org, julien.grall@linaro.org, tim@xen.org, jintack@cs.columbia.edu, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Thu, 2015-02-19 at 10:22 +0000, Ian Campbell wrote: > > >>> + printk("Bad mode in %s handler detected", handler[reason]); > > >>> + printk("ESR=0x%08"PRIx32": EC=%"PRIx32", IL=%"PRIx32", ISS=%"PRIx32"\n", > > >>> + hsr.bits, hsr.ec, hsr.len, hsr.iss); > > >> This would be better as a single printk() call, otherwise a different > > >> cpu issuing a printk() could interleave in the middle of the line. > > >> > > >> Also, you appear to have dropped the space between "detected" and "ESR" > > > That's because I forgot to add the \n to the end of the first printk > > > (the intention was to make the log line <80 columns by splitting it into > > > two lines). Having fixed that I think your first comment then becomes > > > irrelevant? Or is there some benefit to printk("foo\nbar\n")? > > > > Not completely irrelevant, but certainly far less problematic, and > > something I wouldn't worry about. > > Thanks, I think I'll just add the \n on commit Which I've now done. thanks all.