From: Joe Perches <joe@perches.com>
To: Tolga Ceylan <tolga.ceylan@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Roxana Blaj <roxanagabriela10@gmail.com>,
Ana Rey <anarey@gmail.com>, Rui Miguel Silva <rmfrfs@gmail.com>,
Chaitra Ramaiah <linux.delve@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 4/4] Staging: rtl8192u: r819xU_firmware: added space after comma
Date: Thu, 19 Feb 2015 23:30:51 -0800 [thread overview]
Message-ID: <1424417451.18211.6.camel@perches.com> (raw)
In-Reply-To: <1424411651-15978-4-git-send-email-tolga.ceylan@gmail.com>
On Thu, 2015-02-19 at 21:54 -0800, Tolga Ceylan wrote:
> Resolved space required after that ',' errors reported by checkpatch.
trivia:
> diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c b/drivers/staging/rtl8192u/r819xU_firmware.c
[]
> @@ -66,7 +66,7 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
> skb = dev_alloc_skb(USB_HWDESC_HEADER_LEN + frag_length + 4);
> if (!skb)
> return false;
> - memcpy((unsigned char *)(skb->cb),&dev,sizeof(dev));
> + memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
Might as well remove the unnecessary cast too:
memcpy(skb->cb, &dev, sizeof(dev));
but it might be better to avoid the memcpy and use an assign
*(struct net_device *)skb->cb = dev;
next prev parent reply other threads:[~2015-02-20 7:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 5:54 [PATCH 1/4] Staging: rtl8192u: r819xU_firmware: removed commented out variable Tolga Ceylan
2015-02-20 5:54 ` [PATCH 2/4] Staging: rtl8192u: r819xU_firmware: removed commented out assert Tolga Ceylan
2015-02-20 5:54 ` [PATCH 3/4] Staging: rtl9182u: r819xU_firmware: Replaced C99 comments with C89 Tolga Ceylan
2015-02-20 5:54 ` [PATCH 4/4] Staging: rtl8192u: r819xU_firmware: added space after comma Tolga Ceylan
2015-02-20 7:30 ` Joe Perches [this message]
2015-02-20 19:47 ` Tolga Ceylan
2015-02-21 0:31 ` Tolga Ceylan
2015-02-21 1:59 ` Joe Perches
2015-03-07 0:57 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424417451.18211.6.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=anarey@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.delve@gmail.com \
--cc=rmfrfs@gmail.com \
--cc=roxanagabriela10@gmail.com \
--cc=tolga.ceylan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.