From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v3 08/13] xen/arm: Describe device supported by a driver with dt_match_node Date: Fri, 20 Feb 2015 12:30:13 +0000 Message-ID: <1424435413.30924.207.camel@citrix.com> References: <1422643768-23614-1-git-send-email-julien.grall@linaro.org> <1422643768-23614-9-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YOmio-00037n-2l for xen-devel@lists.xenproject.org; Fri, 20 Feb 2015 12:30:18 +0000 In-Reply-To: <1422643768-23614-9-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Fri, 2015-01-30 at 18:49 +0000, Julien Grall wrote: Subject: "devices" > Xen is currently using list a compatible string to know if the driver "using a list of compatible strings" rather than "if the driver can use device node" I'd say something like "to match drivers against device nodes". > can use device node. This leads to have double definition in the GIC > code. "having double definitions". (aside: can we eventually get rid of that duplication somehow?) > Futhermore Linux drivers is using dt_match_node (actually called of_device_id "Furthermore" and "are using" > in Linux) to list device supported by the drivers. "devices" I'd append one more sentence, something like "Remove the existing compatible field and replace with a dt_match field". Just to make it clear what the change here is. > > Signed-off-by: Julien Grall > Acked-by: Stefano Stabellini The actual code looks fine, with the commit message fixed up as described: Acked-by: Ian Campbell