From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v3 09/13] xen/iommu: arm: Import the SMMU driver from Linux Date: Fri, 20 Feb 2015 13:48:18 +0000 Message-ID: <1424440098.30924.246.camel@citrix.com> References: <1422643768-23614-1-git-send-email-julien.grall@linaro.org> <1422643768-23614-10-git-send-email-julien.grall@linaro.org> <1424435513.30924.209.camel@citrix.com> <54E7379B.1090209@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YOnwR-0001xX-7X for xen-devel@lists.xenproject.org; Fri, 20 Feb 2015 13:48:27 +0000 In-Reply-To: <54E7379B.1090209@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Fri, 2015-02-20 at 13:33 +0000, Julien Grall wrote: > On 20/02/15 12:31, Ian Campbell wrote: > > On Fri, 2015-01-30 at 18:49 +0000, Julien Grall wrote: > >> Based on commit e6b5be2be4e30037eb551e0ed09dd97bd00d85d3. > >> > >> It's a verbatim of the Linux SMMU drivers code. No Xen code has yet been added > >> and the file is not built. > >> > >> Compare to the previous drivers it gains support of PCI. Though it will > >> need a bit of plumbing for Xen. > >> > >> Signed-off-by: Julien Grall > >> Acked-by: Stefano Stabellini > > > > Acked-by: Ian Campbell > > > > (without reading since it is a verbatim copy) > > > > xen/arch/arm/README.LinuxPrimitives lists revisions of a bunch of stuff > > we import from Linux for ease of tracking, should we do something > > similar here, although perhaps just in a comment in the header of the > > file? > > The patch #12 adds in the header the commit used to import the drivers. > > I didn't put here because it's a verbatim copy. Thank, I saw that later, how you have it is fine. > > Regards, >