From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755487AbbBUB7m (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 Feb 2015 20:59:42 -0500
Received: from smtprelay0159.hostedemail.com ([216.40.44.159]:59850 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1754985AbbBUB7l (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 Feb 2015 20:59:41 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3872:4321:4605:5007:6248:6261:7514:10004:10400:10848:11232:11658:11914:12296:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: metal07_8e6cc7f39d42e
X-Filterd-Recvd-Size: 1986
Message-ID: <1424483977.18211.23.camel@perches.com>
Subject: Re: [PATCH 4/4] Staging: rtl8192u: r819xU_firmware: added space
 after comma
From: Joe Perches <joe@perches.com>
To: Tolga Ceylan <tolga.ceylan@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Roxana Blaj <roxanagabriela10@gmail.com>, Ana Rey <anarey@gmail.com>,
        Rui Miguel Silva <rmfrfs@gmail.com>,
        Chaitra Ramaiah <linux.delve@gmail.com>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, Larry Finger <Larry.Finger@lwfinger.net>
Date: Fri, 20 Feb 2015 17:59:37 -0800
In-Reply-To: <CALmu+Sz85C-aqst6o2hiDJ_y9JNRum=6p4rcaz8DSSv2nmpU2g@mail.gmail.com>
References: <1424411651-15978-1-git-send-email-tolga.ceylan@gmail.com>
	 <1424411651-15978-4-git-send-email-tolga.ceylan@gmail.com>
	 <1424417451.18211.6.camel@perches.com>
	 <CALmu+Sww-5Sn5owEP_iJDgVkAAzs+7YQocv1gzBbAze56_AD7g@mail.gmail.com>
	 <CALmu+Sz85C-aqst6o2hiDJ_y9JNRum=6p4rcaz8DSSv2nmpU2g@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.7-0ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2015-02-20 at 16:31 -0800, Tolga Ceylan wrote:
> On Fri, Feb 20, 2015 at 11:47 AM, Tolga Ceylan <tolga.ceylan@gmail.com> wrote:
> > On Thu, Feb 19, 2015 at 11:30 PM, Joe Perches <joe@perches.com> wrote:
> >> Might as well remove the unnecessary cast too:
> >>                 memcpy(skb->cb, &dev, sizeof(dev));
> >> but it might be better to avoid the memcpy and use an assign
> >>         *(struct net_device *)skb->cb = dev;
[]
> Should I sent a new set of patches (including memcpy change)?
> Or reply to the series with a single memcpy change patch?

Let Larry Finger decide if he wants the
patches at all first.