From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753488AbbBUJOz (ORCPT ); Sat, 21 Feb 2015 04:14:55 -0500 Received: from cpsmtpb-ews07.kpnxchange.com ([213.75.39.10]:54905 "EHLO cpsmtpb-ews07.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbbBUJOv (ORCPT ); Sat, 21 Feb 2015 04:14:51 -0500 Message-ID: <1424510089.24292.20.camel@x220> Subject: Re: [PATCH 2/6] CRIS: remove SMP code From: Paul Bolle To: Rabin Vincent Cc: jesper.nilsson@axis.com, linux-cris-kernel@axis.com, linux-kernel@vger.kernel.org Date: Sat, 21 Feb 2015 10:14:49 +0100 In-Reply-To: <20150221004051.GA28839@debian> References: <1424374196-4954-1-git-send-email-rabin@rab.in> <1424374196-4954-2-git-send-email-rabin@rab.in> <1424390763.5308.14.camel@x220> <20150221004051.GA28839@debian> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 21 Feb 2015 09:14:49.0696 (UTC) FILETIME=[D7FF3E00:01D04DB6] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-02-21 at 01:40 +0100, Rabin Vincent wrote: > On Fri, Feb 20, 2015 at 01:06:03AM +0100, Paul Bolle wrote: > > On Thu, 2015-02-19 at 20:29 +0100, Rabin Vincent wrote: > > > The CRIS SMP code cannot be built since there is no (and appears to > > > never have been) a CONFIG_SMP Kconfig option in arch/cris/. Remove it. > > > > Yes, it appears there never was a Kconfig symbol SMP for cris so this > > probably was dead code ever since it was added in, I think, v2.6.13. (I > > should mention I didn't review this patch, or cris' apparently > > non-functional SMP code, in detail.) > > > > Mind if I ask how you spotted this? > > If you're asking if I used some kind of script, no, I didn't. I just > noticed it while working on other CRIS patches. Yes. See, I run a script locally. It is rather simple and only catches the more obvious kconfig related mistakes. I'm pretty sure I won't bother teaching it to spot mistakes like this one. But other people are working on a sophisticated bot that might be able to catch those. But, anyhow, just paying attention when fiddling with a piece of code and spotting possible oddities is of course greatly appreciated! Paul Bolle