From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ivan T. Ivanov" Subject: Re: [PATCH V4 2/2] spmi: pmic_arb: add support for hw version 2 Date: Mon, 23 Feb 2015 11:59:14 +0200 Message-ID: <1424685554.2340.2.camel@mm-sol.com> References: <1424386453-18092-1-git-send-email-gavidov@codeaurora.org> <1424386453-18092-3-git-send-email-gavidov@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from ns.mm-sol.com ([37.157.136.199]:39923 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbbBWJ7T (ORCPT ); Mon, 23 Feb 2015 04:59:19 -0500 In-Reply-To: <1424386453-18092-3-git-send-email-gavidov@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Gilad Avidov Cc: sdharia@codeaurora.org, mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, galak@codeaurora.org, agross@codeaurora.org Hi Gilad, On Thu, 2015-02-19 at 15:54 -0700, Gilad Avidov wrote: > Qualcomm PMIC Arbiter version-2 changes from version-1 are: >=20 > - Some different register offsets. > - New channel register space, one per PMIC peripheral (ppid). > All tx traffic uses these channels. > - New observer register space. All rx trafic uses this space. > - Different command format for spmi command registers. >=20 > Acked-by: Sagar Dharia > Signed-off-by: Gilad Avidov =20 > @@ -645,12 +796,67 @@ static int spmi_pmic_arb_probe(struct platform_= device *pdev) > pa->spmic =3D ctrl; >=20 > res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "c= ore"); > - pa->base =3D devm_ioremap_resource(&ctrl->dev, res); > - if (IS_ERR(pa->base)) { > - err =3D PTR_ERR(pa->base); > + core =3D devm_ioremap_resource(&ctrl->dev, res); > + if (IS_ERR(core)) { > + err =3D PTR_ERR(core); > goto err_put_ctrl; > } >=20 > + hw_ver =3D readl_relaxed(core + PMIC_ARB_VERSION); > + is_v1 =3D (hw_ver < PMIC_ARB_VERSION_V2_MIN); > + > + dev_info(&ctrl->dev, "PMIC Arb Version-%d (0x%x)\n", (is_v1 ?= 1 : 2), > + hw_ver); > + > + if (is_v1) { > + pa->ver_ops =3D &pmic_arb_v1; > + pa->wr_base =3D core; > + pa->rd_base =3D core; > + } else { > + u8 chan; > + u16 ppid; > + u32 regval; > + > + pa->ver_ops =3D &pmic_arb_v2; > + devm_iounmap(&ctrl->dev, core); > + > + pa->ppid_to_chan =3D devm_kzalloc(&ctrl->dev, > + PPID_TO_CHAN_TABLE_SZ, GFP_KE= RNEL); > + if (!pa->ppid_to_chan) { > + err =3D -ENOMEM; > + goto err_put_ctrl; > + } > + /* > + * PMIC_ARB_REG_CHNL is a table in HW mapping = channel to ppid. > + * ppid_to_chan is an in-memory invert of that= table. > + */ > + for (chan =3D 0; chan < PMIC_ARB_MAX_CHNL; ++chan) { > + regval =3D readl_relaxed(pa->rd_base + rd_base is not initialized at this point. > + = =20 > PMIC_ARB_REG_CHNL(chan)); > + if (!regval) > + continue; > + > + ppid =3D (regval >> 8) & 0xFFF; > + pa->ppid_to_chan[ppid] =3D chan; > + } > + > + res =3D platform_get_resource_byname(pdev, IORESOURCE= _MEM, > + = "obsrvr"); > + pa->rd_base =3D devm_ioremap_resource(&ctrl->dev, res= ); and they are compile warnings: drivers/spmi/spmi-pmic-arb.c: In function =E2=80=98pmic_arb_read_cmd=E2= =80=99: drivers/spmi/spmi-pmic-arb.c:310:4: warning: format =E2=80=98%d=E2=80=99= expects argument of type =E2=80=98int=E2=80=99, but argument 4 has typ= e =E2=80=98size_t=E2=80=99 [-Wformat=3D] PMIC_ARB_MAX_TRANS_BYTES, len); ^ drivers/spmi/spmi-pmic-arb.c: In function =E2=80=98pmic_arb_write_cmd=E2= =80=99: drivers/spmi/spmi-pmic-arb.c:357:4: warning: format =E2=80=98%d=E2=80=99= expects argument of type =E2=80=98int=E2=80=99, but argument 4 has typ= e =E2=80=98size_t=E2=80=99 [-Wformat=3D] PMIC_ARB_MAX_TRANS_BYTES, len); ^ Ivan