From: Johannes Berg <johannes@sipsolutions.net>
To: James Minor <james.minor@ni.com>
Cc: linville@tuxdriver.com, davem@davemloft.net,
linux-wireless@vger.kernel.org, xander.huff@ni.com, joshc@ni.com,
joseph.hershberger@ni.com, ben.shelton@ni.com,
jaeden.amero@ni.com, rich.tollerton@ni.com, brad.mouring@ni.com
Subject: Re: [PATCH v2] wext: Return -E2BIG when the buffer is too small for the full scan results, including IEs.
Date: Mon, 23 Feb 2015 16:57:24 +0100 [thread overview]
Message-ID: <1424707044.3075.14.camel@sipsolutions.net> (raw)
In-Reply-To: <1424382142-13346-1-git-send-email-james.minor@ni.com>
On Thu, 2015-02-19 at 15:42 -0600, James Minor wrote:
> +#define CHECK_BUF_FULL(p, c, e) \
> + do { \
> + if (unlikely(p == c)) \
> + e = -E2BIG; \
> + } while (0)
I think this would be nicer as a static inline that returned -E2BIG, or
the passed in err, instead of modifying the macro argument.
johannes
next prev parent reply other threads:[~2015-02-23 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 21:04 [PATCH RFC] wext: Add event stream wrappers that return E2BIG when values don't fit Xander Huff
2015-01-29 21:04 ` Xander Huff
2015-01-29 21:22 ` Johannes Berg
2015-02-19 21:31 ` James Minor
2015-02-19 21:42 ` [PATCH v2] wext: Return -E2BIG when the buffer is too small for the full scan results, including IEs James Minor
2015-02-23 15:57 ` Johannes Berg [this message]
2015-02-24 18:58 ` [PATCH v3] " James Minor
2015-02-25 10:34 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424707044.3075.14.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ben.shelton@ni.com \
--cc=brad.mouring@ni.com \
--cc=davem@davemloft.net \
--cc=jaeden.amero@ni.com \
--cc=james.minor@ni.com \
--cc=joseph.hershberger@ni.com \
--cc=joshc@ni.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rich.tollerton@ni.com \
--cc=xander.huff@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.