All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Vijay Kilari <vijay.kilari@gmail.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Julien Grall <julien.grall@linaro.org>, Tim Deegan <tim@xen.org>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Stefano Stabellini <stefano.stabellini@citrix.com>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: [RFC PATCH] xen/arm: Vmap allocator fails to allocate beyond 128M
Date: Mon, 23 Feb 2015 17:10:29 +0000	[thread overview]
Message-ID: <1424711429.27930.232.camel@citrix.com> (raw)
In-Reply-To: <1424710994.27930.226.camel@citrix.com>

On Mon, 2015-02-23 at 17:03 +0000, Ian Campbell wrote:
> MAP_SMALL_PAGES in no way indicates to me "create the PT structure but
> do not map any actual data pages". It is documented on x86 as "don't use
> superpages mappings", which doesn't imply anything to me about
> non-superpage mappings either.

OK I get it now, MAP_SMALL_PAGES is actually a modifier for the PAGE_*
stuff, what's special about this particular usage is that it is a bare
MAP_SMALL_PAGES, i.e. not PAGE_HYPERVISOR|MAP_SMALL_PAGES.

Being bare it then lacks the present bit from PAGE_HYPERVISOR. It's a
bit like saying PAGE_NONE|MAP_SMALL_PAGES (if PAGE_NONE existed)

> Can we along with this fix perhaps rename to something which does
> indicate this. MAP_NON_LEAF_PTS or something perhaps? (This is really a
> question for Jan).

So this then doesn't make any sense, as I'm sure Jan is about to tell
me ;-)

Ian.

  reply	other threads:[~2015-02-23 17:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-17  6:07 [RFC PATCH] xen/arm: Vmap allocator fails to allocate beyond 128M Vijay Kilari
2015-02-17  9:53 ` Jan Beulich
2015-02-17 14:50 ` Julien Grall
2015-02-23 17:07   ` Ian Campbell
2015-02-23 21:45     ` Julien Grall
2015-02-24  8:49       ` Ian Campbell
2015-02-23 17:03 ` Ian Campbell
2015-02-23 17:10   ` Ian Campbell [this message]
2015-02-24 10:01   ` Jan Beulich
2015-02-24 10:20     ` Ian Campbell
2015-02-24 10:24       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424711429.27930.232.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien.grall@linaro.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=vijay.kilari@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.