From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com,
Prasun.Kapoor@caviumnetworks.com,
vijaya.kumar@caviumnetworks.com, tim@xen.org,
xen-devel@lists.xen.org, stefano.stabellini@citrix.com,
manish.jaggi@caviumnetworks.com
Subject: Re: [PATCH v2 1/3] xen/arm: Add ThunderX platform support
Date: Mon, 23 Feb 2015 17:51:04 +0000 [thread overview]
Message-ID: <1424713864.27930.253.camel@citrix.com> (raw)
In-Reply-To: <54E487AB.6060703@linaro.org>
On Wed, 2015-02-18 at 12:38 +0000, Julien Grall wrote:
> > + uint64_t addr, size;
Please use paddr_t and PRIpaddr etc.
> > + res = map_mmio_regions(d,
> > + paddr_to_pfn(addr & PAGE_MASK),
> > + DIV_ROUND_UP(size, PAGE_SIZE),
> > + paddr_to_pfn(addr & PAGE_MASK));
>
> OOI, why this region is not described in the DT? Is it a PCI device?
I'm curious too.
> > + if ( res )
> > + {
> > + printk(XENLOG_ERR "Unable to map to dom%d region"
>
> It would be more clear to specify the name of the region i.e "GSER region"
Agreed.
Ian.
next prev parent reply other threads:[~2015-02-23 17:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 12:19 [PATCH v2 0/3] Add ThunderX platform support vijay.kilari
2015-02-18 12:19 ` [PATCH v2 1/3] xen/arm: " vijay.kilari
2015-02-18 12:38 ` Julien Grall
2015-02-23 17:51 ` Ian Campbell [this message]
2015-03-03 5:09 ` Vijay Kilari
2015-03-03 9:03 ` Ian Campbell
2015-03-03 9:29 ` Vijay Kilari
2015-03-03 10:18 ` Ian Campbell
2015-02-18 12:19 ` [PATCH v2 2/3] xen/arm: Add early printk support for ThunderX platform vijay.kilari
2015-02-23 17:51 ` Ian Campbell
2015-02-18 12:19 ` [PATCH v2 3/3] xen/arm: Skip parsing psci-0.2 from host device tree vijay.kilari
2015-02-23 17:52 ` Ian Campbell
2015-02-23 21:43 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424713864.27930.253.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=julien.grall@linaro.org \
--cc=manish.jaggi@caviumnetworks.com \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=vijay.kilari@gmail.com \
--cc=vijaya.kumar@caviumnetworks.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.