From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v1] xen/arm: Do not allocate pte entries for
 MAP_SMALL_PAGES
Date: Tue, 24 Feb 2015 10:26:02 +0000
Message-ID: <1424773562.27930.301.camel@citrix.com>
References: <1424264213-30614-1-git-send-email-vijay.kilari@gmail.com>
	<54E48DAB.5030307@linaro.org> <1424770282.27930.259.camel@citrix.com>
	<54EC4699.8050905@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54EC4699.8050905@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-02-24 at 09:38 +0000, Julien Grall wrote:
> Hi Ian,
> 
> On 24/02/2015 09:31, Ian Campbell wrote:
> > On Wed, 2015-02-18 at 13:03 +0000, Julien Grall wrote:
> >>> +                {
> >>> +                    pte = mfn_to_xen_entry(mfn, (ai & 0xffff));
> >>
> >> Please introduce a new macro for the mask.
> >
> > Better would be a pte_foo accessor, similar (if not identical) to x86's
> > pte_get_flags. So pte_get_flags(ai) or so.
> 
> I'm not able to find a such function in x86. Did you intend to mean 
> pte_flags_to_cacheattr?

It's actually get_pte_flags.

> In another side, using PTE_PRESENT would require to introduce a 
> PAGE_AVAIL0 (or smth similar).

Why?

> > #define PTE_PRESENT ((struct lpae_t){ .pt.present = 1 }).bits
> >
> > probably doesn't work, I'm not even sure if this sort of thing is
> > possible. If not then "#define PTE_PRESET (1ULL<<0)".
> 
> The attribute index (write-alloc, buferrable...) is using the less 
> significant 3 bits. So I was suggesting to use the top of the word.

I was suggesting to use bits 2..4 as in the real PTE, to be more similar
to the x86 interpretation of this argument.

Ian.