From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [RFC] [Design] Better XL support of RTDS scheduler
	for Xen 4.6
Date: Tue, 24 Feb 2015 10:37:23 +0000
Message-ID: <1424774243.27930.310.camel@citrix.com>
References: <CAENZ-+=izNJSPYbfaPtdoXJD85QRpvv+Y0ySDx0SB41Gc511zQ@mail.gmail.com>
	<20150223155724.GB20083@zion.uk.xensource.com>
	<CAENZ-+mxtuakz=vjQSkeMX9AHxLh=vPJJ4HQ0nhHP8UvSM5WvQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YQCst-00075t-Js
	for xen-devel@lists.xenproject.org; Tue, 24 Feb 2015 10:38:35 +0000
In-Reply-To: <CAENZ-+mxtuakz=vjQSkeMX9AHxLh=vPJJ4HQ0nhHP8UvSM5WvQ@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Meng Xu <xumengpanda@gmail.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Sisu Xi <xisisu@gmail.com>, George Dunlap <george.dunlap@eu.citrix.com>, Dario Faggioli <dario.faggioli@citrix.com>, Chao Wang <chaowang@wustl.edu>, Ian Jackson <ian.jackson@eu.citrix.com>, Chenyang Lu <lu.wustl@gmail.com>, Oleg Sokolsky <sokolsky@cis.upenn.edu>, Linh Thi Xuan Phan <linhphan@cis.upenn.edu>, Insup Lee <lee@cis.upenn.edu>, Chris Gill <cdgill@cse.wustl.edu>, Chong Li <lichong659@gmail.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Dagaen Golomb <dgolomb@seas.upenn.edu>, "mengxu@cis.upenn.edu" <mengxu@cis.upenn.edu>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-02-23 at 22:58 -0500, Meng Xu wrote:
> I'm not sure if other schedulers need such functionality right now,
> because the credit2 scheduler account for the credit based on each
> domain instead of each VCPU. But if the scheduler will consider the
> vcpu-level credit/budget accounting, this could be helpful.

We should take it as given that some other scheduler will want
vcpu-level parameters in the future and decide now how we want that
interface to look across multiple schedulers now, with the big question
I suppose being a large union struct vs individual structs (and perhaps
a KeyedUnion).

At the domain level param level we have libxl_domain_sched_params in
libxl_domain_build_info and via libxl_domain_sched_params_set/get.

We also have libxl_sched_credit_params and
libxl_sched_credit_params_get/set for the credit scheduler, but not for
other scheduler types.

I don't recall how we ended up with both, are the credit ones
deprecated/legacy and the combined one the One True Way or the other way
around?

In any case, we should decide what we want for both per-domain and
per-vcpu parameters, with one eye on the libxl API guarantees, and try
and have them at least be somewhat consistent.

Ian.