From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2] tools/hotplug: Don't ever kill xenstored Date: Tue, 24 Feb 2015 16:43:38 +0000 Message-ID: <1424796218.27930.391.camel@citrix.com> References: <1424765150-642-1-git-send-email-ross.lagerwall@citrix.com> <20150224114552.GG20083@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150224114552.GG20083@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Ross Lagerwall , Olaf Hering , Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2015-02-24 at 11:45 +0000, Wei Liu wrote: > On Tue, Feb 24, 2015 at 08:05:50AM +0000, Ross Lagerwall wrote: > > Don't kill xenstored as part of the usual service shutdown process to > > prevent hangs on shutdown where the kernel tries to unplug a VIF > > after xenstored has exited. > > > > In an ideal case with all guests cooperating, xendomains will have shut > > down all guests before xenstored is killed. > > > > However in the uncooperative case, malicious or crashed guests may still > > be running after xendomains has exited and this should not block the > > shutdown/reboot of dom0. > > > > Xenstored has no state to sync to disk, and never used to be killed in > > the sysvinit case; observe the warning in xencommons. Our testing has > > shown regressions caused by the change in behaviour between sysvinit and > > systemd when it comes to killing xenstored. > > > > Signed-off-by: Ross Lagerwall > > Acked-by: Wei Liu Thanks. I added "systemd: " to the subject and applied.