From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 6/7] build system: stubdom targets now
 depends on mini-os target
Date: Tue, 24 Feb 2015 17:01:26 +0000
Message-ID: <1424797286.20243.12.camel@citrix.com>
References: <1424431072-3842-1-git-send-email-wei.liu2@citrix.com>
	<1424431072-3842-7-git-send-email-wei.liu2@citrix.com>
	<1424795597.27930.383.camel@citrix.com>
	<20150224165230.GN20083@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150224165230.GN20083@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-02-24 at 16:52 +0000, Wei Liu wrote:
> On Tue, Feb 24, 2015 at 04:33:17PM +0000, Ian Campbell wrote:
> > On Fri, 2015-02-20 at 11:17 +0000, Wei Liu wrote:
> > > @@ -161,7 +163,7 @@ clean-tools:
> > >  	$(MAKE) -C tools clean
> > >  
> > >  .PHONY: clean-stubdom
> > > -clean-stubdom:
> > > +clean-stubdom: mini-os-dir
> > >  	$(MAKE) -C stubdom crossclean
> > >  ifeq (x86_64,$(XEN_TARGET_ARCH))
> > >  	XEN_TARGET_ARCH=x86_32 $(MAKE) -C stubdom crossclean
> > > @@ -187,11 +189,12 @@ distclean-tools:
> > >  	$(MAKE) -C tools distclean
> > >  
> > >  .PHONY: distclean-stubdom
> > > -distclean-stubdom:
> > > +distclean-stubdom: mini-os-dir
> > 
> > These two are a bit odd, since they will force a clone in order to clean
> > (and in the distclean case immediately discard again).
> > 
> 
> That's because stubdom's distclean is quite broken, it just won't work
> without mini-os.

If the mini-os dir is not present then I don't think there is any need
to distclean the stubdom, is there? How would anything be present?

> 
> > The way we handle this with e.g. qemu is to have
> > subdir-clean-qemu-xen-traditional-dir:
> >         set -e; if test -d qemu-xen-traditional-dir/.; then \
> >                 $(MAKE) -C qemu-xen-traditional-dir clean; \
> >         fi
> > 
> > so I think you want a pair of {clean,distclean}-mini-os-dir rules which
> > recurse iff the dir exists.
> > 
> 
> No, we don't actually need to enter mini-os dir and make clean /
> distclean when doing clean and distclean of stubdom.

Didn't you just contradict what you said further above?