From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] insane.bbclass: Enhance file-rdeps QA check
Date: Tue, 24 Feb 2015 23:44:55 +0000 [thread overview]
Message-ID: <1424821495.26813.23.camel@linuxfoundation.org> (raw)
In-Reply-To: <1424718281-9133-1-git-send-email-alejandro.hernandez@linux.intel.com>
On Mon, 2015-02-23 at 13:04 -0600, Alejandro Hernandez wrote:
> Adds symlink-to-sysroot check to the QA_WARN, Changes filerdepends
> from set() to dict(), hence methodsfor adding or deleting items had
> to change, keeps track of the key:value relationship, flags the
> issue along with the offending file accordingly.
I'm sure this is a good change but I'm struggling to understand it from
the message above. Could you make sure to say:
a) What the change does
b) Why its important/useful
as well as how the change modifies the code (which you cover).
Cheers,
Richard
prev parent reply other threads:[~2015-02-24 23:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 19:04 [PATCH] insane.bbclass: Enhance file-rdeps QA check Alejandro Hernandez
2015-02-23 19:49 ` Otavio Salvador
2015-02-25 21:43 ` Alejandro Hernandez
2015-02-24 23:44 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424821495.26813.23.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=alejandro.hernandez@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.