From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH 5/8] standalone: Always set OSSTEST_NO_BASELINE Date: Wed, 25 Feb 2015 13:26:35 +0000 Message-ID: <1424870795.20243.101.camel@citrix.com> References: <1424869277-16764-1-git-send-email-ian.jackson@eu.citrix.com> <1424869277-16764-6-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YQbz9-0001EP-Ji for xen-devel@lists.xenproject.org; Wed, 25 Feb 2015 13:26:43 +0000 In-Reply-To: <1424869277-16764-6-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-02-25 at 13:01 +0000, Ian Jackson wrote: > OSSTEST_NO_BASELINE disables the thing where cr-daily-branch decides > (based on information from sg-check-tested) that the baseline is > untested and therefore that it ought to do a baseline test instead of > testing the tip. > > This whole feature is never correct in standalone mode, where there is > no useful test history database for sg-check-tested to work on. > > In the case where the branch was osstest, not specifying --baseline > and therefore not having OSSTEST_NO_BASELINE didn't make all that much > difference because we also have OSSTEST_USE_HEAD=y and currently > ap-fetch-version-old (wrongfully) honours that, so the `baseline' test > would use the head anyway. > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell Although: > - --baseline)nobaseline=n; shift 1;; > + --baseline) echo >&2 'warning: --baseline is obsolete'; shift 1;; TBH I think you could just nuke it from a tool like this. I rather suspect noone is using it... I can't even remember why I wanted it.