Re: [PATCH 3/4] xen: sched: make counters for vCPU tickling generic

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 729 bytes --]

On Thu, 2015-02-26 at 15:22 +0000, Jan Beulich wrote:
> >>> On 26.02.15 at 14:37, <dario.faggioli@citrix.com> wrote:
> > --- a/xen/common/sched_credit2.c
> > +++ b/xen/common/sched_credit2.c
> > @@ -571,9 +571,11 @@ tickle:
> >                    (unsigned char *)&d);
> >      }
> >      cpumask_set_cpu(ipid, &rqd->tickled);
> > +    SCHED_STAT_CRANK(tickle_idlers_some);
> >      cpu_raise_softirq(ipid, SCHEDULE_SOFTIRQ);
> >  
> >  no_tickle:
> > +    SCHED_STAT_CRANK(tickle_idlers_none);
> >      return;
> >  }
> 
> Isn't there a return statement missing ahead of "no_tickle:" now?
> 
There is. I reworked this last minute, and overlooked this... sorry.
Will fix for v2.

Thanks and Regards,
Dario

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel