From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 3/4] xen: sched: make counters for vCPU
	tickling generic
Date: Thu, 26 Feb 2015 15:31:47 +0000
Message-ID: <1424964705.4742.213.camel@citrix.com>
References: <20150226131406.15590.21081.stgit@Solace.station>
	<20150226133710.15590.827.stgit@Solace.station>
	<54EF48520200007800064256@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3383493470876706192=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54EF48520200007800064256@mail.emea.novell.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "JBeulich@suse.com" <JBeulich@suse.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, "xumengpanda@gmail.com" <xumengpanda@gmail.com>, George Dunlap <George.Dunlap@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

--===============3383493470876706192==
Content-Language: en-US
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-G0yCB9a6YrWX+BMHJOZy"

--=-G0yCB9a6YrWX+BMHJOZy
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2015-02-26 at 15:22 +0000, Jan Beulich wrote:
> >>> On 26.02.15 at 14:37, <dario.faggioli@citrix.com> wrote:
> > --- a/xen/common/sched_credit2.c
> > +++ b/xen/common/sched_credit2.c
> > @@ -571,9 +571,11 @@ tickle:
> >                    (unsigned char *)&d);
> >      }
> >      cpumask_set_cpu(ipid, &rqd->tickled);
> > +    SCHED_STAT_CRANK(tickle_idlers_some);
> >      cpu_raise_softirq(ipid, SCHEDULE_SOFTIRQ);
> > =20
> >  no_tickle:
> > +    SCHED_STAT_CRANK(tickle_idlers_none);
> >      return;
> >  }
>=20
> Isn't there a return statement missing ahead of "no_tickle:" now?
>=20
There is. I reworked this last minute, and overlooked this... sorry.
Will fix for v2.

Thanks and Regards,
Dario

--=-G0yCB9a6YrWX+BMHJOZy
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlTvPGEACgkQk4XaBE3IOsSOYQCeNdkZuhZd9nPo7cTTGoyUIfxk
Nc8AoKnxytADT3l0swGd1PtDxEk9j7uk
=lWKB
-----END PGP SIGNATURE-----

--=-G0yCB9a6YrWX+BMHJOZy--


--===============3383493470876706192==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============3383493470876706192==--