From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v6 11/23] libxl: functions to build
 vmemranges for PV guest
Date: Thu, 26 Feb 2015 16:39:40 +0000
Message-ID: <1424968775.4742.216.camel@citrix.com>
References: <1424966166-2388-1-git-send-email-wei.liu2@citrix.com>
	<1424966166-2388-12-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2036536523487019372=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1424966166-2388-12-git-send-email-wei.liu2@citrix.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <Ian.Jackson@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, "ufimtseva@gmail.com" <ufimtseva@gmail.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

--===============2036536523487019372==
Content-Language: en-US
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-iyZ7wAuU/lEjcoAa8AK+"

--=-iyZ7wAuU/lEjcoAa8AK+
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2015-02-26 at 15:55 +0000, Wei Liu wrote:
> Introduce a arch-independent routine to generate one vmemrange per
> vnode. Also introduce arch-dependent routines for different
> architectures because part of the process is arch-specific -- ARM has
> yet have NUMA support and E820 is x86 only.
>=20
> For those x86 guests who care about machine E820 map (i.e. with
> e820_host=3D1), vnode is further split into several vmemranges to
> accommodate memory holes.  A few stubs for libxl_arm.c are created.
>=20
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Dario Faggioli <dario.faggioli@citrix.com>
> Cc: Elena Ufimtseva <ufimtseva@gmail.com>

> diff --git a/tools/libxl/libxl_vnuma.c b/tools/libxl/libxl_vnuma.c
> index 33d7a3c..04672b5 100644
> --- a/tools/libxl/libxl_vnuma.c
> +++ b/tools/libxl/libxl_vnuma.c
> @@ -14,6 +14,7 @@
>   */
>  #include "libxl_osdeps.h" /* must come before any other headers */
>  #include "libxl_internal.h"
> +#include "libxl_arch.h"
>  #include <stdlib.h>
> =20
>  /* Sort vmemranges in ascending order with "start" */
> @@ -142,6 +143,46 @@ out:
>      return rc;
>  }
> =20
> +
Aren't you adding an extra, unnecessary, blank line here?

> +int libxl__vnuma_build_vmemrange_pv_generic(libxl__gc *gc,
> +                                            uint32_t domid,
> +                                            libxl_domain_build_info *b_i=
nfo,
> +                                            libxl__domain_build_state *s=
tate)
>

<snip>

Of course, my Reviewed-by still stands... I just noticed this while
having a quick look. So, if you happen to have to resend... :-)

Regards,
Dario

--=-iyZ7wAuU/lEjcoAa8AK+
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlTvTEgACgkQk4XaBE3IOsSFOACfU7ITveStORgkkoJtMOVoSNuJ
LlcAnREhuarf0hFq4FQFHktyqlwKGO5b
=HvH8
-----END PGP SIGNATURE-----

--=-iyZ7wAuU/lEjcoAa8AK+--


--===============2036536523487019372==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============2036536523487019372==--