From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] correct mis-conversion set_bit() ->
 __cpumask_set_cpu() by 4aaca0e9cd
Date: Fri, 27 Feb 2015 10:34:58 +0000
Message-ID: <1425033298.14641.157.camel@citrix.com>
References: <54EB17A802000078000626F9@mail.emea.novell.com>
	<1581919702.20150226175335@eikelenboom.it>
	<54F02BD50200007800064679@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YRIGA-0005mW-Ao
	for xen-devel@lists.xenproject.org; Fri, 27 Feb 2015 10:35:06 +0000
In-Reply-To: <54F02BD50200007800064679@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Sander Eikelenboom <linux@eikelenboom.it>, Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-02-27 at 07:33 +0000, Jan Beulich wrote:
> >>> On 26.02.15 at 17:53, <linux@eikelenboom.it> wrote:
> 
> > Monday, February 23, 2015, 12:06:00 PM, you wrote:
> > 
> >> I have no idea how I came to use __cpumask_set_cpu() there, the
> >> conversion should have been set_bit() -> __set_bit(). The wrong
> >> construct results in problems on systems with relatively few CPUs.
> > 
> >> Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > 
> >> --- a/xen/common/softirq.c
> >> +++ b/xen/common/softirq.c
> >> @@ -106,7 +106,7 @@ void cpu_raise_softirq(unsigned int cpu,
> >>      if ( !per_cpu(batching, this_cpu) || in_irq() )
> >>          smp_send_event_check_cpu(cpu);
> >>      else
> >> -        __cpumask_set_cpu(nr, &per_cpu(batch_mask, this_cpu));
> >> +        __set_bit(nr, &per_cpu(batch_mask, this_cpu));
> >>  }
> >>  
> >>  void cpu_raise_softirq_batch_begin(void)
> > 
> > Hi Jan,
> > 
> > Any reason this wasn't applied to staging yet ?
> 
> It didn't get ack-ed

Sorry, I thought this was an x86 patch for some reason and therefore
that Andrew's ack was sufficient.

For v2 of the patch (<54EB3D880200007800062834@mail.emea.novell.com>,
using __cpumask_set_cpu(cpu, ...):

Acked-by: Ian Campbell <ian.campbell@citrix.com>