From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 3/4] xen: sched: make counters for vCPU
	tickling generic
Date: Fri, 27 Feb 2015 10:53:32 +0000
Message-ID: <1425034409.10194.49.camel@citrix.com>
References: <20150226131406.15590.21081.stgit@Solace.station>
	<20150226133710.15590.827.stgit@Solace.station>
	<CAENZ-+=MtqUn1XT5Wk0=7qL82bBgU4F8HpDw544UdeBqy_WcEA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5540590607882762441=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAENZ-+=MtqUn1XT5Wk0=7qL82bBgU4F8HpDw544UdeBqy_WcEA@mail.gmail.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "xumengpanda@gmail.com" <xumengpanda@gmail.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, George Dunlap <George.Dunlap@citrix.com>, "JBeulich@suse.com" <JBeulich@suse.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

--===============5540590607882762441==
Content-Language: en-US
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-SPFwz7g78ZDJp3gu0EjC"

--=-SPFwz7g78ZDJp3gu0EjC
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2015-02-27 at 00:47 -0500, Meng Xu wrote:

> 2015-02-26 8:37 GMT-05:00 Dario Faggioli <dario.faggioli@citrix.com>:
>         and update them from Credit2 and RTDS schedulers.
>        =20
>         Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
>         Cc: Meng Xu <xumengpanda@gmail.com>
>         Cc: George Dunlap <george.dunlap@eu.citrix.com>
>         Cc: Jan Beulich <JBeulich@suse.com>
>         Cc: Keir Fraser <keir@xen.org>
>         ---
>          xen/common/sched_credit2.c   |    2 ++
>          xen/common/sched_rt.c        |    2 ++
>          xen/include/xen/perfc_defn.h |    4 ++--
>          3 files changed, 6 insertions(+), 2 deletions(-)
>=20
> =E2=80=8BThe change for RTDS scheduler looks good to me.
>
Does this count as a "Reviewed-by: Meng Xu <mengxu@cis.upenn.edu>" ?

Also, if yes, does it also apply to patch #2 ? That is unclear as
sched_rt.c is modified in patches #1, #2 ad #3, while what you did is:
 - you explicitly provided the tag for patch #1
 - you said "looks good" for this for patch #3
 - you said nothing for patch #2

The bottom line of all this being: with Ack-s/Reviewed-by-s, it's always
better be pretty explicit! :-D

Thanks and Regards,
Dario


--=-SPFwz7g78ZDJp3gu0EjC
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlTwTKkACgkQk4XaBE3IOsQamgCfSBYN0X0AnwIbpv5cD6pxMbXw
rOYAn0dfDPFHOrg2ZQY5Os5fAwCyIaVr
=CDKt
-----END PGP SIGNATURE-----

--=-SPFwz7g78ZDJp3gu0EjC--


--===============5540590607882762441==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============5540590607882762441==--