From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 3/5] x86: widen NUMA nodes to be allocated
	from
Date: Fri, 27 Feb 2015 13:27:21 +0000
Message-ID: <1425043639.10194.67.camel@citrix.com>
References: <54EF315902000078000640FF@mail.emea.novell.com>
	<54EF33A60200007800064144@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3861148545531088644=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <dario.faggioli@citrix.com>) id 1YRKwu-0007yp-Kv
	for xen-devel@lists.xenproject.org; Fri, 27 Feb 2015 13:27:24 +0000
In-Reply-To: <54EF33A60200007800064144@mail.emea.novell.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "JBeulich@suse.com" <JBeulich@suse.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, Julien Grall <julien.grall@citrix.com>, Stefano Stabellini <Stefano.Stabellini@citrix.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

--===============3861148545531088644==
Content-Language: en-US
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-8YS/wwtbnC6BJysJKmWV"

--=-8YS/wwtbnC6BJysJKmWV
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2015-02-26 at 13:54 +0000, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

One question (a genuine one, i.e., I'm really not sure what I'm saying
is correct).

After this series, vcpu_to_node() (defined in xen/include/xen/numa.h) is
left with only one use, in xen/arch/arm/domain.c, besides of course
being used to implement domain_to_node() (still in
xen/include/xen/numa.h).

So, provided ARM people (and I'm Cc-ing them) can get rid of that, can
that macro be removed all together, and domain_to_node(d) be defined
after d->node_affinity... something like:

 #define domain_to_node(d) \
   ( nodes_equal(d->node_affinity, NODE_MASK_ALL) \
     ? NUMA_NO_NODE : first_node(d->node_affinity) )=20

I'm asking because I really don't like vcpu_to_node(). And I'm not
talking about how it is implemented (there probably are not much
alternatives), I'm saying I don't think it should exist, and I really
would see value in killing it. :-)

Thoughts?

Thanks and Regards,
Dario

--=-8YS/wwtbnC6BJysJKmWV
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlTwcLcACgkQk4XaBE3IOsRNyACfSFMkGVuEobW4gTq3mRL9fHOk
Bg4AoKSsoxCoxDApu1CF0q1btYMjV5ll
=ZWwM
-----END PGP SIGNATURE-----

--=-8YS/wwtbnC6BJysJKmWV--


--===============3861148545531088644==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============3861148545531088644==--