From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Date: Sat, 28 Feb 2015 10:02:29 +0000 Subject: [PATCH 6/7] mtd: blkdevs: remove dead code Message-Id: <1425117750-22298-7-git-send-email-computersforpeace@gmail.com> List-Id: References: <1425117750-22298-1-git-send-email-computersforpeace@gmail.com> In-Reply-To: <1425117750-22298-1-git-send-email-computersforpeace@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-mtd@lists.infradead.org Cc: Brian Norris , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org The only exit (break) from the preceding loop is nested within a condition which yields req = NULL. This code is dead. Coverity CID #752669 Signed-off-by: Brian Norris --- drivers/mtd/mtd_blkdevs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index d08229eb44d8..2b0c52870999 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -171,9 +171,6 @@ static void mtd_blktrans_work(struct work_struct *work) background_done = 0; } - if (req) - __blk_end_request_all(req, -EIO); - spin_unlock_irq(rq->queue_lock); } -- 2.1.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pd0-x22c.google.com ([2607:f8b0:400e:c02::22c]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YReEx-0000AL-P1 for linux-mtd@lists.infradead.org; Sat, 28 Feb 2015 10:03:20 +0000 Received: by pdno5 with SMTP id o5so26966586pdn.8 for ; Sat, 28 Feb 2015 02:03:00 -0800 (PST) From: Brian Norris To: Subject: [PATCH 6/7] mtd: blkdevs: remove dead code Date: Sat, 28 Feb 2015 02:02:29 -0800 Message-Id: <1425117750-22298-7-git-send-email-computersforpeace@gmail.com> In-Reply-To: <1425117750-22298-1-git-send-email-computersforpeace@gmail.com> References: <1425117750-22298-1-git-send-email-computersforpeace@gmail.com> Cc: Brian Norris , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , The only exit (break) from the preceding loop is nested within a condition which yields req == NULL. This code is dead. Coverity CID #752669 Signed-off-by: Brian Norris --- drivers/mtd/mtd_blkdevs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index d08229eb44d8..2b0c52870999 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -171,9 +171,6 @@ static void mtd_blktrans_work(struct work_struct *work) background_done = 0; } - if (req) - __blk_end_request_all(req, -EIO); - spin_unlock_irq(rq->queue_lock); } -- 2.1.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751164AbbB1KDL (ORCPT ); Sat, 28 Feb 2015 05:03:11 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:44184 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921AbbB1KDA (ORCPT ); Sat, 28 Feb 2015 05:03:00 -0500 From: Brian Norris To: Cc: Brian Norris , , kernel-janitors@vger.kernel.org Subject: [PATCH 6/7] mtd: blkdevs: remove dead code Date: Sat, 28 Feb 2015 02:02:29 -0800 Message-Id: <1425117750-22298-7-git-send-email-computersforpeace@gmail.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1425117750-22298-1-git-send-email-computersforpeace@gmail.com> References: <1425117750-22298-1-git-send-email-computersforpeace@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The only exit (break) from the preceding loop is nested within a condition which yields req == NULL. This code is dead. Coverity CID #752669 Signed-off-by: Brian Norris --- drivers/mtd/mtd_blkdevs.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index d08229eb44d8..2b0c52870999 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -171,9 +171,6 @@ static void mtd_blktrans_work(struct work_struct *work) background_done = 0; } - if (req) - __blk_end_request_all(req, -EIO); - spin_unlock_irq(rq->queue_lock); } -- 2.1.0